From: Matthias Kestenholz <mk@spinlock.ch>
To: gitster@pobox.com
Cc: git@vger.kernel.org, Matthias Kestenholz <matthias@spinlock.ch>
Subject: [PATCH 2/4] git branch: Use color configuration infrastructure
Date: Sat, 5 Jan 2008 15:11:37 +0100 [thread overview]
Message-ID: <1199542299-12082-2-git-send-email-mk@spinlock.ch> (raw)
In-Reply-To: <1199542299-12082-1-git-send-email-mk@spinlock.ch>
From: Matthias Kestenholz <matthias@spinlock.ch>
Signed-off-by: Matthias Kestenholz <matthias@spinlock.ch>
---
builtin-branch.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/builtin-branch.c b/builtin-branch.c
index 089cae5..448144f 100644
--- a/builtin-branch.c
+++ b/builtin-branch.c
@@ -31,7 +31,6 @@ static unsigned char head_sha1[20];
static int branch_track = 1;
-static int branch_use_color;
static char branch_colors[][COLOR_MAXLEN] = {
"\033[m", /* reset */
"", /* PLAIN (normal) */
@@ -65,7 +64,7 @@ static int parse_branch_color_slot(const char *var, int ofs)
static int git_branch_config(const char *var, const char *value)
{
if (!strcmp(var, "color.branch")) {
- branch_use_color = git_config_colorbool(var, value, -1);
+ git_use_color = git_config_colorbool(var, value, -1);
return 0;
}
if (!prefixcmp(var, "color.branch.")) {
@@ -76,12 +75,12 @@ static int git_branch_config(const char *var, const char *value)
if (!strcmp(var, "branch.autosetupmerge"))
branch_track = git_config_bool(var, value);
- return git_default_config(var, value);
+ return git_color_default_config(var, value);
}
static const char *branch_get_color(enum color_branch ix)
{
- if (branch_use_color)
+ if (git_use_color > 0)
return branch_colors[ix];
return "";
}
@@ -559,7 +558,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
OPT_GROUP("Generic options"),
OPT__VERBOSE(&verbose),
OPT_BOOLEAN( 0 , "track", &track, "set up tracking mode (see git-pull(1))"),
- OPT_BOOLEAN( 0 , "color", &branch_use_color, "use colored output"),
+ OPT_BOOLEAN( 0 , "color", &git_use_color, "use colored output"),
OPT_SET_INT('r', NULL, &kinds, "act on remote-tracking branches",
REF_REMOTE_BRANCH),
OPT_CALLBACK(0, "contains", &with_commit, "commit",
@@ -585,6 +584,8 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
};
git_config(git_branch_config);
+ git_color_config();
+
track = branch_track;
argc = parse_options(argc, argv, options, builtin_branch_usage, 0);
if (!!delete + !!rename + !!force_create > 1)
--
1.5.4.rc2.1104.gec8ae5-dirty
next prev parent reply other threads:[~2008-01-05 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 8:35 [PATCH] add--interactive: allow diff colors without interactive colors Jeff King
2008-01-05 0:20 ` Junio C Hamano
2008-01-05 3:37 ` Jeff King
2008-01-05 8:01 ` Junio C Hamano
2008-01-05 8:51 ` Jeff King
2008-01-05 9:28 ` Junio C Hamano
2008-01-05 9:57 ` Jeff King
2008-01-05 10:58 ` [PATCH/resend] " Matthias Kestenholz
2008-01-05 11:11 ` Junio C Hamano
2008-01-05 14:10 ` Matthias Kestenholz
2008-01-05 14:11 ` [PATCH 1/4] Add infrastructure for a single color config variable Matthias Kestenholz
2008-01-05 14:11 ` Matthias Kestenholz [this message]
2008-01-05 14:11 ` [PATCH 3/4] status and commit: Use color configuration infrastructure Matthias Kestenholz
2008-01-05 14:11 ` [PATCH 4/4] diff and log: " Matthias Kestenholz
2008-01-08 11:23 ` [PATCH 2/4] git branch: " Jeff King
2008-01-08 12:52 ` Matthias Kestenholz
2008-01-05 11:37 ` [PATCH/resend] add--interactive: allow diff colors without interactive colors Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199542299-12082-2-git-send-email-mk@spinlock.ch \
--to=mk@spinlock.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=matthias@spinlock.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).