git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gustaf Hendeby <hendeby@isy.liu.se>
To: Seth Falcon <seth@userprimary.net>, gitster@pobox.com
Cc: git@vger.kernel.org, Gustaf Hendeby <hendeby@isy.liu.se>
Subject: [PATCH] send-email, fix breakage in combination with --compose
Date: Mon, 21 Jan 2008 20:57:46 +0100	[thread overview]
Message-ID: <1200945466-21154-2-git-send-email-hendeby@isy.liu.se> (raw)
In-Reply-To: <1200945466-21154-1-git-send-email-hendeby@isy.liu.se>

This fixes the subtile bug in git send-email that was introduced into
git send-email with

commit aa54892f5ada8282643dc7387b33261c7135d784
send-email: detect invocation errors earlier

causing no patches to be sent out if the --compose flag was used.

Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se>
---
 git-send-email.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-send-email.perl b/git-send-email.perl
index 6c72952..a1a9d14 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -462,7 +462,7 @@ EOT
 		exit(0);
 	}
 
-	@files = ($compose_filename . ".final");
+	@files = ($compose_filename . ".final", @files);
 }
 
 # Variables we set as part of the loop over files
-- 
1.5.4.rc4.1.gbdcdb

  reply	other threads:[~2008-01-21 19:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-21 18:30 git-send-email not sending? Seth Falcon
2008-01-21 19:57 ` Test of send-email patch Gustaf Hendeby
2008-01-21 19:57   ` Gustaf Hendeby [this message]
2008-01-22  0:05     ` [PATCH] send-email, fix breakage in combination with --compose Seth Falcon
2008-01-22  3:19     ` Jeff King
2008-01-22  3:23       ` [PATCH 1/3] t9001: add missing && operators Jeff King
2008-01-22  3:25         ` [PATCH 2/3] t9001: enhance fake sendmail test harness Jeff King
2008-01-22  3:29           ` [PATCH 3/3] send-email: test compose functionality Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1200945466-21154-2-git-send-email-hendeby@isy.liu.se \
    --to=hendeby@isy.liu.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=seth@userprimary.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).