From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: git@vger.kernel.org
Cc: "Roger C. Soares" <rogersoares@intelinet.com.br>,
Dave Watson <dwatson@mimvista.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Robin Rosenberg <robin.rosenberg@dewire.com>
Subject: [EGIT PATCH 1/6] Comment some empty blocks that should be empty
Date: Tue, 5 Feb 2008 01:15:29 +0100 [thread overview]
Message-ID: <1202170534-15788-2-git-send-email-robin.rosenberg@dewire.com> (raw)
In-Reply-To: <1202170534-15788-1-git-send-email-robin.rosenberg@dewire.com>
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
---
.../src/org/spearce/egit/core/test/Activator.java | 1 +
.../internal/actions/AbstractOperationAction.java | 1 +
.../egit/ui/internal/dialogs/CommitDialog.java | 3 +++
.../ui/internal/preferences/GitPreferencePage.java | 1 +
.../spearce/jgit/lib/AbstractIndexTreeVisitor.java | 4 ++++
.../org/spearce/jgit/lib/TopologicalSorter.java | 1 +
6 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/org.spearce.egit.core.test/src/org/spearce/egit/core/test/Activator.java b/org.spearce.egit.core.test/src/org/spearce/egit/core/test/Activator.java
index 9807c84..10d7d94 100644
--- a/org.spearce.egit.core.test/src/org/spearce/egit/core/test/Activator.java
+++ b/org.spearce.egit.core.test/src/org/spearce/egit/core/test/Activator.java
@@ -18,6 +18,7 @@ public class Activator extends Plugin {
* The constructor
*/
public Activator() {
+ // Empty
}
/*
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/AbstractOperationAction.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/AbstractOperationAction.java
index c3f347e..0e96323 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/AbstractOperationAction.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/actions/AbstractOperationAction.java
@@ -73,6 +73,7 @@ public abstract class AbstractOperationAction implements IObjectActionDelegate {
* A method to invoke when the operation is finished.
*/
protected void postOperation() {
+ // Empty
}
public void run(final IAction act) {
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
index 3778b94..064a2dc 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/dialogs/CommitDialog.java
@@ -212,6 +212,7 @@ public class CommitDialog extends Dialog {
}
public void widgetDefaultSelected(SelectionEvent arg0) {
+ // Empty
}
});
@@ -242,9 +243,11 @@ public class CommitDialog extends Dialog {
public void inputChanged(Viewer viewer, Object oldInput,
Object newInput) {
+ // Empty
}
public void dispose() {
+ // Empty
}
public Object[] getElements(Object inputElement) {
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/preferences/GitPreferencePage.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/preferences/GitPreferencePage.java
index 780375b..8e6d3f3 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/preferences/GitPreferencePage.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/preferences/GitPreferencePage.java
@@ -36,5 +36,6 @@ public class GitPreferencePage extends PreferencePage implements
}
public void init(final IWorkbench workbench) {
+ // Empty
}
}
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/AbstractIndexTreeVisitor.java b/org.spearce.jgit/src/org/spearce/jgit/lib/AbstractIndexTreeVisitor.java
index 40b42dd..6f5ede4 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/AbstractIndexTreeVisitor.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/AbstractIndexTreeVisitor.java
@@ -31,17 +31,21 @@ import org.spearce.jgit.lib.GitIndex.Entry;
public class AbstractIndexTreeVisitor implements IndexTreeVisitor {
public void finishVisitTree(Tree tree, Tree auxTree, int i, String curDir)
throws IOException {
+ // Empty
}
public void finishVisitTree(Tree tree, int i, String curDir)
throws IOException {
+ // Empty
}
public void visitEntry(TreeEntry treeEntry, Entry indexEntry, File file)
throws IOException {
+ // Empty
}
public void visitEntry(TreeEntry treeEntry, TreeEntry auxEntry,
Entry indexEntry, File file) throws IOException {
+ // Empty
}
}
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalSorter.java b/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalSorter.java
index 7b59490..c33334e 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalSorter.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/TopologicalSorter.java
@@ -292,6 +292,7 @@ public class TopologicalSorter<T> {
private int number = -1;
Lane() {
+ // Empty
}
@Override
--
1.5.4.rc4.25.g81cc
next prev parent reply other threads:[~2008-02-05 0:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 0:15 [EGIT PATCH Series] Cleanups and javadocs Robin Rosenberg
2008-02-05 0:15 ` Robin Rosenberg [this message]
2008-02-05 0:15 ` [EGIT PATCH 2/6] Cleanup unboxing/boxing Robin Rosenberg
2008-02-05 0:15 ` [EGIT PATCH 3/6] Do not require javadoc in egit.core test project Robin Rosenberg
2008-02-05 0:15 ` [EGIT PATCH 4/6] Javadoc update for Egit Robin Rosenberg
2008-02-05 0:15 ` [EGIT PATCH 5/6] Drop unused GitBlobStorage class Robin Rosenberg
2008-02-05 0:15 ` [EGIT PATCH 6/6] Tighten requirements on javadoc Robin Rosenberg
2008-02-06 7:06 ` [EGIT PATCH 2/6] Cleanup unboxing/boxing Shawn O. Pearce
2008-02-06 20:14 ` [EGIT PATCH 1/2] Use Boolean.valueOf instead of new Boolean Robin Rosenberg
2008-02-06 20:15 ` [EGIT PATCH 2/2] Use Integer.valueOf instead of new Integer Robin Rosenberg
2008-02-08 2:52 ` Roger C. Soares
2008-02-05 15:09 ` [EGIT PATCH Series] Cleanups and javadocs Roger C. Soares
2008-02-05 21:47 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202170534-15788-2-git-send-email-robin.rosenberg@dewire.com \
--to=robin.rosenberg@dewire.com \
--cc=dwatson@mimvista.com \
--cc=git@vger.kernel.org \
--cc=rogersoares@intelinet.com.br \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).