From: Dmitry Potapov <dpotapov@gmail.com>
To: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Cc: Dmitry Potapov <dpotapov@gmail.com>
Subject: [PATCH] git help -w should not create nohup.out
Date: Fri, 8 Feb 2008 04:33:41 +0300 [thread overview]
Message-ID: <1202434421-8066-1-git-send-email-dpotapov@gmail.com> (raw)
git-help--browse uses 'nohup' to launch some browsers. If the output is not
redirected, 'nohup' creates 'nohup.out' and prints a warning about that. It
was mighty annoying to see this warning as well as to have empty nohup.out
files scattered everywhere you happened to use 'git help -w'.
This patch redirects the output to /dev/null when a GUI browser is launched
using the 'nohup' command; thus 'nohup.out' is not created.
Signed-off-by: Dmitry Potapov <dpotapov@gmail.com>
---
Initially I thought to redict the output to $HOME/.git-nohup.out instead of
/dev/null, so no output will be lost if an error happen. But the only error
that a GUI browser may want to report to the stderr or stdout is a problem
inside Xlib (like connection to X display or something like that), and when
it happens you cannot run your favorite browser from the command line anyway.
So, it is very noticeably and no problem to diagnose without any nohup.out
created by git help.
git-help--browse.sh | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-help--browse.sh b/git-help--browse.sh
index 10b0a36..320e836 100755
--- a/git-help--browse.sh
+++ b/git-help--browse.sh
@@ -122,7 +122,7 @@ case "$browser" in
vers=$(expr "$($browser_path -version)" : '.* \([0-9][0-9]*\)\..*')
NEWTAB='-new-tab'
test "$vers" -lt 2 && NEWTAB=''
- nohup "$browser_path" $NEWTAB $pages &
+ nohup "$browser_path" $NEWTAB $pages > /dev/null &
;;
konqueror)
case "$(basename "$browser_path")" in
@@ -136,7 +136,7 @@ case "$browser" in
eval "$browser_path" newTab $pages
;;
*)
- nohup "$browser_path" $pages &
+ nohup "$browser_path" $pages > /dev/null &
;;
esac
;;
@@ -144,6 +144,6 @@ case "$browser" in
eval "$browser_path" $pages
;;
dillo)
- nohup "$browser_path" $pages &
+ nohup "$browser_path" $pages > /dev/null &
;;
esac
--
1.5.4
next reply other threads:[~2008-02-08 1:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 1:33 Dmitry Potapov [this message]
2008-02-08 1:55 ` [PATCH] git help -w should not create nohup.out Johannes Schindelin
2008-02-08 3:40 ` Junio C Hamano
2008-02-08 5:37 ` Christian Couder
2008-02-08 11:25 ` Dmitry Potapov
2008-02-08 10:33 ` Dmitry Potapov
2008-02-08 20:36 ` [PATCH] remove "nohup" from git-help--browse Dmitry Potapov
2008-02-09 5:53 ` Christian Couder
2008-02-09 20:03 ` Dmitry Potapov
2008-02-10 2:02 ` Junio C Hamano
2008-02-10 2:06 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202434421-8066-1-git-send-email-dpotapov@gmail.com \
--to=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).