From: Dmitry Potapov <dpotapov@gmail.com>
To: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <chriscool@tuxfamily.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Dmitry Potapov <dpotapov@gmail.com>
Subject: [PATCH] remove "nohup" from git-help--browse
Date: Fri, 8 Feb 2008 23:36:22 +0300 [thread overview]
Message-ID: <1202502982-6822-1-git-send-email-dpotapov@gmail.com> (raw)
In-Reply-To: <7vhcgkm7yy.fsf@gitster.siamese.dyndns.org>
There is no good reason to run GUI browsers using "nohup". It does not
solve any real problem but creates annoying "nohup.out" files in every
directory where git help -w is run.
This patch removes "nohup" from git-help--browse.sh
Signed-off-by: Dmitry Potapov <dpotapov@gmail.com>
---
It seems that everyone is agree that there is no good reason to
keep "nohup" in git-help--browse. So here is the patch.
git-help--browse.sh | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-help--browse.sh b/git-help--browse.sh
index 10b0a36..adc4d37 100755
--- a/git-help--browse.sh
+++ b/git-help--browse.sh
@@ -122,7 +122,7 @@ case "$browser" in
vers=$(expr "$($browser_path -version)" : '.* \([0-9][0-9]*\)\..*')
NEWTAB='-new-tab'
test "$vers" -lt 2 && NEWTAB=''
- nohup "$browser_path" $NEWTAB $pages &
+ "$browser_path" $NEWTAB $pages &
;;
konqueror)
case "$(basename "$browser_path")" in
@@ -136,7 +136,7 @@ case "$browser" in
eval "$browser_path" newTab $pages
;;
*)
- nohup "$browser_path" $pages &
+ "$browser_path" $pages &
;;
esac
;;
@@ -144,6 +144,6 @@ case "$browser" in
eval "$browser_path" $pages
;;
dillo)
- nohup "$browser_path" $pages &
+ "$browser_path" $pages &
;;
esac
--
1.5.4
next prev parent reply other threads:[~2008-02-08 20:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 1:33 [PATCH] git help -w should not create nohup.out Dmitry Potapov
2008-02-08 1:55 ` Johannes Schindelin
2008-02-08 3:40 ` Junio C Hamano
2008-02-08 5:37 ` Christian Couder
2008-02-08 11:25 ` Dmitry Potapov
2008-02-08 10:33 ` Dmitry Potapov
2008-02-08 20:36 ` Dmitry Potapov [this message]
2008-02-09 5:53 ` [PATCH] remove "nohup" from git-help--browse Christian Couder
2008-02-09 20:03 ` Dmitry Potapov
2008-02-10 2:02 ` Junio C Hamano
2008-02-10 2:06 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1202502982-6822-1-git-send-email-dpotapov@gmail.com \
--to=dpotapov@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).