Re: [RFC] Build in clone

["Kristian Høgsberg" <krh@redhat.com>]

On Tue, 2008-02-26 at 12:36 -0500, Daniel Barkalow wrote:
> On Tue, 26 Feb 2008, Johan Herland wrote:
> 
> > Other than the failing tests, it seems to work fairly well. I've been
> > playing around with it for a few minutes, and on a test repo I have with
> > 1001 branches and 10000 tags, it cuts down the runtime of a local git-clone
> > from 25 seconds to ~1.5 seconds. (simply by eliminating the overhead of
> > invoking git-update-ref for every single ref) :)
> 
> Good to hear. A certain amount of the point is performance, and I've only 
> got relatively simple repositories on Linux to test with, where everything 
> is too fast to tell anyway.

Yeah, that's pretty cool.

> > - Fix "clone from $repo" reflog messages (using strbufs; something tells
> >   me more of this code would benefit from using strbufs)
> 
> Most likely. I think Kristian wrote most of this before strbuf existed or 
> something of the sort.

No this was after the strbuf API went in.  The "clone from $repo"
messages I just left at the time because I was lazy, but yeah, they'll
need some strbuf love, or maybe just snprintf.  I don't agree that
strbuf applies very well for the rest of the code.  I'm a big fan of the
strbuf functionality, but I've been very deliberate about using and not
using it.

cheers,
Kristian