From: Marc-Andre Lureau <marcandre.lureau@gmail.com>
To: git@vger.kernel.org
Cc: Martin Langhoff <martin@catalyst.net.nz>,
Marc-Andre Lureau <marcandre.lureau@gmail.com>
Subject: [PATCH] git-cvsimport: fix initial checkout
Date: Thu, 13 Mar 2008 21:09:38 +0200 [thread overview]
Message-ID: <1205435378-10411-1-git-send-email-marcandre.lureau@gmail.com> (raw)
git-symbolic-ref HEAD returns master reference, even if the file does
not exists. That prevents the initial checkout and fails in
git-rev-parse. The patch checks the existence of the reference file
before assuming an original branch exists. There might be better
solutions than checking file existence.
---
git-cvsimport.perl | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/git-cvsimport.perl b/git-cvsimport.perl
index 95c5eec..1512fe4 100755
--- a/git-cvsimport.perl
+++ b/git-cvsimport.perl
@@ -570,12 +570,16 @@ unless (-d $git_dir) {
open(F, "git-symbolic-ref HEAD |") or
die "Cannot run git-symbolic-ref: $!\n";
chomp ($last_branch = <F>);
- $last_branch = basename($last_branch);
- close(F);
- unless ($last_branch) {
+ if (-f "$git_dir/$last_branch") {
+ $last_branch = basename($last_branch);
+ unless ($last_branch) {
warn "Cannot read the last branch name: $! -- assuming 'master'\n";
$last_branch = "master";
+ }
+ } else {
+ $last_branch = "";
}
+ close(F);
$orig_branch = $last_branch;
$tip_at_start = `git-rev-parse --verify HEAD`;
@@ -953,6 +957,7 @@ while (<CVS>) {
print "* UNKNOWN LINE * $_\n";
}
}
+
commit() if $branch and $state != 11;
unless ($opt_P) {
--
1.5.4.4.534.gfb90c.dirty
next reply other threads:[~2008-03-13 19:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-13 19:09 Marc-Andre Lureau [this message]
2008-03-13 21:05 ` [PATCH] git-cvsimport: fix initial checkout Junio C Hamano
2008-03-13 22:18 ` Martin Langhoff
2008-03-13 23:04 ` Marc-André Lureau
2008-03-13 23:07 ` Marc-André Lureau
2008-03-13 23:29 ` Martin Langhoff
2008-03-13 23:15 ` Junio C Hamano
2008-03-13 23:27 ` Martin Langhoff
2008-03-13 23:22 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205435378-10411-1-git-send-email-marcandre.lureau@gmail.com \
--to=marcandre.lureau@gmail.com \
--cc=git@vger.kernel.org \
--cc=martin@catalyst.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).