From: Kevin Ballard <kevin@sb.org>
To: git@vger.kernel.org
To: Eric Wong <normalperson@yhbt.net>
Cc: Kevin Ballard <kevin@sb.org>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: [PATCH] Make git-svn tests behave better on OS X
Date: Fri, 21 Mar 2008 03:27:35 -0400 [thread overview]
Message-ID: <1206084455-2793-1-git-send-email-kevin@sb.org> (raw)
In-Reply-To: <7vod98r210.fsf@gitster.siamese.dyndns.org>
This patch works fine for me.
-->8--
Give lib-git-svn.sh a few alternate paths to look for apache2.
Explicitly define the LockFile so httpd will actually start under OS X
Signed-off-by: Kevin Ballard <kevin@sb.org>
---
t/lib-git-svn.sh | 25 +++++++++++++++++++++++--
1 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh
index 9ee35e7..9decd2e 100644
--- a/t/lib-git-svn.sh
+++ b/t/lib-git-svn.sh
@@ -49,8 +49,28 @@ poke() {
test-chmtime +1 "$1"
}
-SVN_HTTPD_MODULE_PATH=${SVN_HTTPD_MODULE_PATH-'/usr/lib/apache2/modules'}
-SVN_HTTPD_PATH=${SVN_HTTPD_PATH-'/usr/sbin/apache2'}
+for d in \
+ "$SVN_HTTPD_PATH" \
+ /usr/sbin/apache2 \
+ /usr/sbin/httpd \
+; do
+ if test -f "$d"
+ then
+ SVN_HTTPD_PATH="$d"
+ break
+ fi
+done
+for d in \
+ "$SVN_HTTPD_MODULE_PATH" \
+ /usr/lib/apache2/modules \
+ /usr/libexec/apache2 \
+; do
+ if test -d "$d"
+ then
+ SVN_HTTPD_MODULE_PATH="$d"
+ break
+ fi
+done
start_httpd () {
if test -z "$SVN_HTTPD_PORT"
@@ -66,6 +86,7 @@ ServerName "git-svn test"
ServerRoot "$GIT_DIR"
DocumentRoot "$GIT_DIR"
PidFile "$GIT_DIR/httpd.pid"
+LockFile logs/accept.lock
Listen 127.0.0.1:$SVN_HTTPD_PORT
LoadModule dav_module $SVN_HTTPD_MODULE_PATH/mod_dav.so
LoadModule dav_svn_module $SVN_HTTPD_MODULE_PATH/mod_dav_svn.so
--
1.5.5.rc0.23.gf91eb
next prev parent reply other threads:[~2008-03-21 7:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 20:08 [PATCH resend 1/2] Make git-svn tests behave better on OS X Kevin Ballard
2008-03-20 20:08 ` [PATCH resend 2/2] Don't try and percent-escape existing percent escapes in git-svn URIs Kevin Ballard
2008-03-21 6:51 ` Eric Wong
2008-03-21 6:52 ` Junio C Hamano
2008-03-21 6:58 ` [PATCH resend 1/2] Make git-svn tests behave better on OS X Eric Wong
2008-03-21 7:04 ` Junio C Hamano
2008-03-21 7:27 ` Kevin Ballard [this message]
2008-03-22 19:35 ` [PATCH] " Eric Wong
-- strict thread matches above, loose matches on Subject: below --
2008-03-08 22:28 Kevin Ballard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206084455-2793-1-git-send-email-kevin@sb.org \
--to=kevin@sb.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).