From: "Jörg Sommer" <joerg@alea.gnuu.de>
To: git@vger.kernel.org
Cc: B.Steinbrink@gmx.de, "Jörg Sommer" <joerg@alea.gnuu.de>
Subject: [PATCH 2/3] Change rebase with preserver merges to pick up the right new HEAD
Date: Sat, 22 Mar 2008 22:44:25 +0100 [thread overview]
Message-ID: <1206222266-29179-2-git-send-email-joerg@alea.gnuu.de> (raw)
In-Reply-To: <1206222266-29179-1-git-send-email-joerg@alea.gnuu.de>
The assumtion that the new HEAD is the rewritten old head is wrong. The
new HEAD is the (maybe rewritten) last commit in the list.
Signed-off-by: Jörg Sommer <joerg@alea.gnuu.de>
---
git-rebase--interactive.sh | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 8aa7371..dec18a3 100755
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -20,6 +20,7 @@ require_work_tree
DOTEST="$GIT_DIR/.dotest-merge"
TODO="$DOTEST"/git-rebase-todo
DONE="$DOTEST"/done
+LAST_SHA1="$DOTEST"/last_sha1
MSG="$DOTEST"/message
SQUASH_MSG="$DOTEST"/message-squash
REWRITTEN="$DOTEST"/rewritten
@@ -251,6 +252,7 @@ do_next () {
pick|p)
comment_for_reflog pick
+ echo $sha1 > "$LAST_SHA1"
mark_action_done
pick_one $sha1 ||
die_with_patch $sha1 "Could not apply $sha1... $rest"
@@ -258,6 +260,7 @@ do_next () {
edit|e)
comment_for_reflog edit
+ echo $sha1 > "$LAST_SHA1"
mark_action_done
pick_one $sha1 ||
die_with_patch $sha1 "Could not apply $sha1... $rest"
@@ -280,6 +283,7 @@ do_next () {
has_action "$DONE" ||
die "Cannot 'squash' without a previous commit"
+ echo $sha1 > "$LAST_SHA1"
mark_action_done
make_squash_message $sha1 > "$MSG"
case "$(peek_next_command)" in
@@ -333,11 +337,12 @@ do_next () {
test -f "$DOTEST"/current-commit &&
current_commit=$(cat "$DOTEST"/current-commit) &&
git rev-parse HEAD > "$REWRITTEN"/$current_commit
- if test -f "$REWRITTEN"/$OLDHEAD
+ last_sha1=$(git rev-parse $(cat "$LAST_SHA1"))
+ if test -f "$REWRITTEN"/$last_sha1
then
- NEWHEAD=$(cat "$REWRITTEN"/$OLDHEAD)
+ NEWHEAD=$(cat "$REWRITTEN"/$last_sha1)
else
- NEWHEAD=$OLDHEAD
+ NEWHEAD=$last_sha1
fi
else
NEWHEAD=$(git rev-parse HEAD)
--
1.5.4.4
next prev parent reply other threads:[~2008-03-22 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-22 21:44 [PATCH 1/3] Add test for rebase interactive with preserve merges Jörg Sommer
2008-03-22 21:44 ` Jörg Sommer [this message]
2008-03-22 21:44 ` [PATCH 3/3] Improve failure test for " Jörg Sommer
2008-03-22 21:57 ` Jörg Sommer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206222266-29179-2-git-send-email-joerg@alea.gnuu.de \
--to=joerg@alea.gnuu.de \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).