git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tim Harper <timcharper@gmail.com>
To: git@vger.kernel.org
Cc: Tim Harper <timcharper@gmail.com>
Subject: [PATCH] "not uptodate" changed to "has local changes"
Date: Sat,  3 May 2008 10:59:32 -0600	[thread overview]
Message-ID: <1209833972-12256-1-git-send-email-timcharper@gmail.com> (raw)

When doing a merge, the message says "file.txt: needs update", or "file.txt: not uptodate, cannot merge".   While internally 'uptodate' makes sense, from the outside it's a mystery.

This patch will make git a little more human friendly, reporting "file.txt: has local changes".
---
 read-cache.c   |    2 +-
 unpack-trees.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/read-cache.c b/read-cache.c
index a92b25b..e890b27 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -999,7 +999,7 @@ int refresh_index(struct index_state *istate, unsigned int flags, const char **p
 			}
 			if (quiet)
 				continue;
-			printf("%s: needs update\n", ce->name);
+			printf("%s: has local changes\n", ce->name);
 			has_errors = 1;
 			continue;
 		}
diff --git a/unpack-trees.c b/unpack-trees.c
index a59f475..1d67e08 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -427,7 +427,7 @@ static int verify_uptodate(struct cache_entry *ce,
 	if (errno == ENOENT)
 		return 0;
 	return o->gently ? -1 :
-		error("Entry '%s' not uptodate. Cannot merge.", ce->name);
+		error("Entry '%s' has local changes. Cannot merge.", ce->name);
 }
 
 static void invalidate_ce_path(struct cache_entry *ce, struct unpack_trees_options *o)
-- 
1.5.5.1

             reply	other threads:[~2008-05-03 17:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-03 16:59 Tim Harper [this message]
2008-05-06 13:31 ` [PATCH] "not uptodate" changed to "has local changes" Mike Ralphson
2008-05-16  2:14   ` André Goddard Rosa
2008-05-16 10:25     ` Johannes Schindelin
2008-05-16 11:02       ` Holger Schurig
2008-05-16 11:50         ` Francis Moreau
2008-05-16 12:22         ` Johannes Schindelin
2008-05-16 17:12       ` Kevin Ballard
2008-05-17  3:30         ` André Goddard Rosa
2008-05-17 10:04           ` Johannes Schindelin
2008-05-17 14:44             ` Steven Walter
2008-05-17 16:12               ` Sverre Rabbelier
2008-05-17 18:44                 ` Johannes Schindelin
2008-05-17 20:14                   ` Sverre Rabbelier
     [not found]                     ` <200805181032.m4IAWjE0012832@mi0.bluebottle.com>
2008-05-18 11:11                       ` Sverre Rabbelier
2008-05-17 19:03                 ` Re* " Junio C Hamano
2008-05-17 20:29                   ` Sverre Rabbelier
2008-05-19  6:55                   ` Wincent Colaiuta
2008-05-19 17:47                     ` Junio C Hamano
2008-05-19 18:28                       ` Sverre Rabbelier
2008-05-19 19:32                       ` Daniel Barkalow
2008-05-21  7:07                         ` Junio C Hamano
2008-05-17 15:08             ` Wincent Colaiuta
2008-05-17 15:32               ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1209833972-12256-1-git-send-email-timcharper@gmail.com \
    --to=timcharper@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).