git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@freescale.com>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: Junio C Hamano <gitster@pobox.com>,
	Christian Couder <chriscool@tuxfamily.org>,
	Pieter de Bie <pdebie@ai.rug.nl>,
	Jakub Narebski <jnareb@gmail.com>,
	Manoj Srivastava <srivasta@ieee.org>,
	Thomas Adam <thomas.adam22@gmail.com>,
	Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] Documentation: bisect: add a few "git bisect run" examples
Date: Wed, 07 May 2008 11:09:20 -0500	[thread overview]
Message-ID: <1210176560.6102.9.camel@ld0161-tx32> (raw)
In-Reply-To: <vpqlk2mbpao.fsf@bauges.imag.fr>

On Wed, 2008-05-07 at 08:29 +0200, Matthieu Moy wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> >> +------------
> >> +echo "#"\!"/bin/sh" > ~/test.sh
> >> +echo "make install || exit 125" >> ~/test.sh
> >> +echo "~/check_test_case.sh" >> ~/test.sh
> >> +chmod u+x ~/test.sh
> >
> > s/install//; let's not set a bad example of installing first and then
> > testing.
> 
> Perhaps also s/~/./g, since it's not a good idea to put temporary
> files in $HOME IMHO.
> 
> Also, using simple quotes instead of double would simplify the
> "#"\!"/bin/sh".

Hmm.  I would have just done "$ cat ~/test.sh" and
then shown the file listing directly.

jdl

      parent reply	other threads:[~2008-05-07 16:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07  4:29 [PATCH 2/2] Documentation: bisect: add a few "git bisect run" examples Christian Couder
2008-05-07  4:59 ` Junio C Hamano
2008-05-07  6:29   ` Matthieu Moy
2008-05-07  7:25     ` Miklos Vajna
2008-05-07 22:18       ` Christian Couder
2008-05-07 16:09     ` Jon Loeliger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1210176560.6102.9.camel@ld0161-tx32 \
    --to=jdl@freescale.com \
    --cc=Matthieu.Moy@imag.fr \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jnareb@gmail.com \
    --cc=pdebie@ai.rug.nl \
    --cc=srivasta@ieee.org \
    --cc=thomas.adam22@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).