From: Miklos Vajna <vmiklos@frugalware.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Pierre Habouzit <madcoder@debian.org>, git@vger.kernel.org
Subject: [PATCH] git-merge: exclude unnecessary options from OPTIONS_SPEC
Date: Mon, 12 May 2008 19:22:56 +0200 [thread overview]
Message-ID: <1210612976-13534-1-git-send-email-vmiklos@frugalware.org> (raw)
In-Reply-To: <20080512160309.GB4821@artemis.madism.org>
gitcli(5) already documents them, and there are no options named
--no-no-stat, --no-no-summary and --no-no-log.
Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---
On Mon, May 12, 2008 at 06:03:09PM +0200, Pierre Habouzit <madcoder@debian.org> wrote:
> > I am wondering if our move should be to remove these negatives
> > instead
> > of adding more like the quoted patch does.
>
> We should removing the no-log and no-commit indeed as there are log
> and
> commit. the fact that --no-foo exists when --foo exists is documented
> in
> gitcli manpage. We can make it even better adding a flag if needed,
> but
> I feel it's not.
Ok, here is an updated version that does this.
git-merge.sh | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/git-merge.sh b/git-merge.sh
index 69b35d8..5fc5f52 100755
--- a/git-merge.sh
+++ b/git-merge.sh
@@ -9,11 +9,9 @@ git-merge [options] <remote>...
git-merge [options] <msg> HEAD <remote>
--
stat show a diffstat at the end of the merge
-n,no-stat don't show a diffstat at the end of the merge
+n don't show a diffstat at the end of the merge
summary (synonym to --stat)
-no-summary (synonym to --no-stat)
log add list of one-line log to merge commit message
-no-log don't add list of one-line log to merge commit message
squash create a single commit instead of doing a merge
commit perform a commit if the merge sucesses (default)
ff allow fast forward (default)
--
1.5.5.1.211.g65ea3.dirty
parent reply other threads:[~2008-05-12 17:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20080512160309.GB4821@artemis.madism.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210612976-13534-1-git-send-email-vmiklos@frugalware.org \
--to=vmiklos@frugalware.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).