git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Koeppen <git-dev@marzelpan.de>
To: gitster@pobox.com
Cc: git@vger.kernel.org, sbejar@gmail.com
Subject: [PATCH] Replace in-place sed in t7502-commit
Date: Fri, 16 May 2008 02:21:43 +0200	[thread overview]
Message-ID: <1210897303-80828-1-git-send-email-git-dev@marzelpan.de> (raw)
In-Reply-To: <7vwslwgdyi.fsf@gitster.siamese.dyndns.org>

The in-place mode of sed used in t7502-commit is a non-POSIX extension.
That call of sed is replaced by a more portable version using a temporary file.

Signed-off-by: Marcel Koeppen <git-dev@marzelpan.de>
---
 t/t7502-commit.sh |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/t/t7502-commit.sh b/t/t7502-commit.sh
index 018060c..3531a99 100755
--- a/t/t7502-commit.sh
+++ b/t/t7502-commit.sh
@@ -166,7 +166,9 @@ test_expect_success 'author different from committer' '
 	test_cmp expect actual
 '
 
-sed -i '$d' expect
+mv expect expect.tmp
+sed '$d' < expect.tmp > expect
+rm -f expect.tmp
 echo "# Committer:
 #" >> expect
 unset GIT_COMMITTER_EMAIL
-- 
1.5.5.1.215.g64c0d

  parent reply	other threads:[~2008-05-16  0:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15  2:19 [PATCH] Fix sed syntax in t7502-commit for OSX Marcel Koeppen
2008-05-15  8:37 ` Junio C Hamano
2008-05-15  8:58   ` Holger Schurig
2008-05-15 11:06     ` Marcel Koeppen
2008-05-15  9:37   ` Santi Béjar
2008-05-16  0:21   ` Marcel Koeppen [this message]
2008-05-16  9:56     ` [PATCH] Replace in-place sed in t7502-commit Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1210897303-80828-1-git-send-email-git-dev@marzelpan.de \
    --to=git-dev@marzelpan.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sbejar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).