git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix prepare-commit-msg hook and replace in-place sed
@ 2008-05-21 16:25 Marcel Koeppen
  0 siblings, 0 replies; only message in thread
From: Marcel Koeppen @ 2008-05-21 16:25 UTC (permalink / raw)
  To: gitster; +Cc: git

The patterns to the case statement could never be matched, so the hook
was a noop. This patch also replaces the non-portable use of in-place sed.

Signed-off-by: Marcel Koeppen <git-dev@marzelpan.de>
---
 templates/hooks--prepare-commit-msg |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/templates/hooks--prepare-commit-msg b/templates/hooks--prepare-commit-msg
index ff0f42a..d3c1da3 100644
--- a/templates/hooks--prepare-commit-msg
+++ b/templates/hooks--prepare-commit-msg
@@ -20,11 +20,11 @@
 # The third example adds a Signed-off-by line to the message, that can
 # still be edited.  This is rarely a good idea.
 
-case "$2 $3" in
-  merge)
-    sed -i '/^Conflicts:/,/#/!b;s/^/# &/;s/^# #/#/' "$1" ;;
+case "$2,$3" in
+  merge,)
+    perl -i -ne 's/^/# /, s/^# #/#/ if /^Conflicts/ .. /#/; print' "$1" ;;
 
-# ""|template)
+# ,|template,)
 #   perl -i -pe '
 #      print "\n" . `git diff --cached --name-status -r`
 #	 if /^#/ && $first++ == 0' "$1" ;;
-- 
1.5.5.1.316.g377d9

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-05-21 16:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-21 16:25 [PATCH] Fix prepare-commit-msg hook and replace in-place sed Marcel Koeppen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).