git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Sverre Hvammen Johansen <hvammen@gmail.com>
Subject: [PATCH 0/6] Forwarding Sverre's "merge --ff=<allow,only,never>" series
Date: Wed, 21 May 2008 18:16:43 -0700	[thread overview]
Message-ID: <1211419009-9741-1-git-send-email-gitster@pobox.com> (raw)

A few weeks ago Sverre's "merge --ff=<allow,only,never>" series was
re-sent to the list but as 6 attachments to a single mail.  The format was
unfortunate and nobody seems to have bothered to read nor comment on.

I think the early patches in the series are at least worth keeping and the
overall series deserves some attention from the list, so I am re-injecting
them in format that can hopefully be commented on and tried out as a
public service ;-) I am tempted to apply up to [3/6] after another round
of reading myself.

A few minor nits I already have:

 [2/6]

"diff -u" in verify_diff() should be "test_cmp":

@@ -254,7 +254,7 @@
 +}
 +
 +verify_diff() {
-+      if ! diff -u "$1" "$2"
++      if ! test_cmp "$1" "$2"
 +      then
 +              echo "$3"
 +              false

 [3/6] 

The argument to --ff is optional (log message):

---ff now takes an argument allowing --ff to be written
-as --ff=allow and -no-ff to be written as --ff=never.
-This change allow other fast forward options to be
-introduced later.
-
-See the documentation for a further explanation of these options.
+The --ff flag now takes an optional argument, allowing --ff to be
+written as --ff=allow and -no-ff to be written as --ff=never. This
+allows other fast forward options to be introduced later.

Also, you usually should not say 'see doc for details' in commit log, as
it does not help anybody.  Either you convince others that your patch is
worth reading by your commit log message alone, or you don't.

Grammar.

 +The first merge of topicA or the only merge of topicB would have
-+resulted in a fast forward without '--ff=never'.  Topic A consist of
++resulted in a fast forward without '--ff=never'.  Topic A consists of
 +those commits that can be reached from master^2 without passing

 [4/6]

Grammar.

 +# Find reduced parents
-+# The following variables are set as follow:
++# The following variables are set as follows:
 +#   reduced_parents: The reduced parents of those specified on the
 command line.

 [6/6]

Commit log:

 instead of a real merge.  This option can then be used to
 avoid an accidental merge.
 
-See the documentation for further details.
-

             reply	other threads:[~2008-05-22  1:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22  1:16 Junio C Hamano [this message]
2008-05-22  1:16 ` [PATCH 1/6] Documentation for joining more than two histories Junio C Hamano
2008-05-22  1:16   ` [PATCH 2/6] New merge tests Junio C Hamano
2008-05-22  1:16     ` [PATCH 3/6] Introduce -ff=<fast forward option> Junio C Hamano
2008-05-22  1:16       ` [PATCH 4/6] Restructure git-merge.sh Junio C Hamano
2008-05-22  1:16         ` [PATCH 5/6] Head reduction before selecting merge strategy Junio C Hamano
2008-05-22  1:16           ` [PATCH 6/6] Introduce fast forward option only Junio C Hamano
2008-05-22 10:48         ` [PATCH 4/6] Restructure git-merge.sh Johannes Schindelin
2008-05-22 12:50           ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211419009-9741-1-git-send-email-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hvammen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).