git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 4/5] unpack_trees(): allow callers to differentiate worktree errors from merge errors
Date: Wed, 28 May 2008 17:17:24 -0700	[thread overview]
Message-ID: <1212020246-26480-5-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1212020246-26480-4-git-send-email-gitster@pobox.com>

Instead of uniformly returning -1 on any error, this teaches
unpack_trees() to return -2 when the merge itself is Ok but worktree
refuses to get updated.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 unpack-trees.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/unpack-trees.c b/unpack-trees.c
index 0de5a31..cba0aca 100644
--- a/unpack-trees.c
+++ b/unpack-trees.c
@@ -358,8 +358,13 @@ static int unpack_failed(struct unpack_trees_options *o, const char *message)
 	return -1;
 }
 
+/*
+ * N-way merge "len" trees.  Returns 0 on success, -1 on failure to manipulate the
+ * resulting index, -2 on failure to reflect the changes to the work tree.
+ */
 int unpack_trees(unsigned len, struct tree_desc *t, struct unpack_trees_options *o)
 {
+	int ret;
 	static struct cache_entry *dfc;
 
 	if (len > MAX_UNPACK_TREES)
@@ -404,11 +409,10 @@ int unpack_trees(unsigned len, struct tree_desc *t, struct unpack_trees_options
 		return unpack_failed(o, "Merge requires file-level merging");
 
 	o->src_index = NULL;
-	if (check_updates(o))
-		return -1;
+	ret = check_updates(o) ? (-2) : 0;
 	if (o->dst_index)
 		*o->dst_index = o->result;
-	return 0;
+	return ret;
 }
 
 /* Here come the merge functions */
-- 
1.5.6.rc0.43.g823ea

  reply	other threads:[~2008-05-29  0:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29  0:17 [PATCH 0/5] "best effort" checkout Junio C Hamano
2008-05-29  0:17 ` [PATCH 1/5] "git checkout -- paths..." should error out when paths cannot be written Junio C Hamano
2008-05-29  0:17   ` [PATCH 2/5] checkout: make reset_clean_to_new() not die by itself Junio C Hamano
2008-05-29  0:17     ` [PATCH 3/5] checkout: consolidate reset_{to_new,clean_to_new|() Junio C Hamano
2008-05-29  0:17       ` Junio C Hamano [this message]
2008-05-29  0:17         ` [PATCH 5/5] checkout: "best effort" checkout Junio C Hamano
2008-05-29  0:17           ` [PATCH 6/5] NUL hack to create_file() Junio C Hamano
2008-05-29  6:33             ` Johannes Sixt
2008-05-29  7:05               ` Marius Storm-Olsen
2008-05-29  7:23                 ` Johannes Sixt
2008-05-29 17:19                 ` Daniel Barkalow
2008-05-29 17:51                   ` Brian Dessent
2008-05-29 18:35                     ` Daniel Barkalow
2008-05-29 12:39               ` Johannes Schindelin
2008-05-29 15:55             ` Daniel Barkalow
2008-05-29 18:26               ` Junio C Hamano
2008-05-29 17:44             ` Alex Riesen
2008-05-29 23:24 ` [PATCH 0/5] "best effort" checkout Mark Levedahl
2008-05-30  0:33   ` Junio C Hamano
2008-05-30  1:09     ` Mark Levedahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212020246-26480-5-git-send-email-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).