git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 6/5] NUL hack to create_file()
Date: Wed, 28 May 2008 17:17:26 -0700	[thread overview]
Message-ID: <1212020246-26480-7-git-send-email-gitster@pobox.com> (raw)
In-Reply-To: <1212020246-26480-6-git-send-email-gitster@pobox.com>

This is not meant for application to the mainline.  It allows your git to
refuse to create a blob whose name is "nul".

---
 entry.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/entry.c b/entry.c
index 222aaa3..d24b803 100644
--- a/entry.c
+++ b/entry.c
@@ -81,6 +81,14 @@ static void remove_subtree(const char *path)
 
 static int create_file(const char *path, unsigned int mode)
 {
+	if (1) {
+		size_t len = strlen(path);
+		if (3 <= len && !strcmp(path + len - 3, "nul") &&
+		    (3 == len || path[len - 4] == '/')) {
+			errno = EPERM;
+			return -1;
+		}
+	}
 	mode = (mode & 0100) ? 0777 : 0666;
 	return open(path, O_WRONLY | O_CREAT | O_EXCL, mode);
 }
-- 
1.5.6.rc0.43.g823ea

  reply	other threads:[~2008-05-29  0:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29  0:17 [PATCH 0/5] "best effort" checkout Junio C Hamano
2008-05-29  0:17 ` [PATCH 1/5] "git checkout -- paths..." should error out when paths cannot be written Junio C Hamano
2008-05-29  0:17   ` [PATCH 2/5] checkout: make reset_clean_to_new() not die by itself Junio C Hamano
2008-05-29  0:17     ` [PATCH 3/5] checkout: consolidate reset_{to_new,clean_to_new|() Junio C Hamano
2008-05-29  0:17       ` [PATCH 4/5] unpack_trees(): allow callers to differentiate worktree errors from merge errors Junio C Hamano
2008-05-29  0:17         ` [PATCH 5/5] checkout: "best effort" checkout Junio C Hamano
2008-05-29  0:17           ` Junio C Hamano [this message]
2008-05-29  6:33             ` [PATCH 6/5] NUL hack to create_file() Johannes Sixt
2008-05-29  7:05               ` Marius Storm-Olsen
2008-05-29  7:23                 ` Johannes Sixt
2008-05-29 17:19                 ` Daniel Barkalow
2008-05-29 17:51                   ` Brian Dessent
2008-05-29 18:35                     ` Daniel Barkalow
2008-05-29 12:39               ` Johannes Schindelin
2008-05-29 15:55             ` Daniel Barkalow
2008-05-29 18:26               ` Junio C Hamano
2008-05-29 17:44             ` Alex Riesen
2008-05-29 23:24 ` [PATCH 0/5] "best effort" checkout Mark Levedahl
2008-05-30  0:33   ` Junio C Hamano
2008-05-30  1:09     ` Mark Levedahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212020246-26480-7-git-send-email-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).