From: David Dillow <dave@thedillows.org>
To: Linus Torvalds <torvalds@linuxfoundation.org>
Cc: "Frank Ch. Eigler" <fche@redhat.com>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: reducing prune sync()s
Date: Thu, 29 May 2008 21:51:35 -0400 [thread overview]
Message-ID: <1212112295.3094.3.camel@obelisk.thedillows.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0805291656260.3141@woody.linux-foundation.org>
On Thu, 2008-05-29 at 17:27 -0700, Linus Torvalds wrote:
> That would be much better. The code was ported from shell script, and
> there is no fsync() in shell, but the rule should basically be that you
> can remove all the objects that correspond to a pack-file after you have
> made sure that the pack-file (and it's index - we can re-generate the pack
> index, but realistically speaking it's *much* better to not have to) is
> stable on disk.
Even if the data is stable on disk, don't we also need to ensure the
pack's connectivity to the namespace is also stable? Without an fsync()
of the directory that contains it, could it go away?
Of course, this is me recollecting a several-year-old exchange on LKML,
so I don't know if it is still needed or not, or on systems other than
Linux.
Dave
next prev parent reply other threads:[~2008-05-30 1:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 20:57 reducing prune sync()s Frank Ch. Eigler
2008-05-30 0:27 ` Linus Torvalds
2008-05-30 0:32 ` Linus Torvalds
2008-05-30 1:50 ` Frank Ch. Eigler
2008-05-30 20:07 ` Florian Weimer
2008-05-30 1:51 ` David Dillow [this message]
2008-05-30 2:17 ` Linus Torvalds
2008-05-30 2:30 ` Linus Torvalds
2008-05-30 15:25 ` Frank Ch. Eigler
2008-05-30 15:57 ` Linus Torvalds
2008-05-30 16:08 ` [PATCH 1/2] Make pack creation always fsync() the result Linus Torvalds
2008-05-30 16:11 ` [PATCH 2/2] Remove now unnecessary 'sync()' calls Linus Torvalds
2008-05-30 20:27 ` [PATCH 1/2] Make pack creation always fsync() the result Nicolas Pitre
2008-05-31 14:19 ` Frank Ch. Eigler
2008-06-02 22:23 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212112295.3094.3.camel@obelisk.thedillows.org \
--to=dave@thedillows.org \
--cc=fche@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).