git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
To: git@vger.kernel.org
Cc: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Subject: [PATCH] Make cell alignment more robust in gitweb blame
Date: Tue,  3 Jun 2008 12:14:20 +0200	[thread overview]
Message-ID: <1212488060-23251-2-git-send-email-rgarciasuarez@gmail.com> (raw)
In-Reply-To: <1212488060-23251-1-git-send-email-rgarciasuarez@gmail.com>

It appears that git-blame's returned group size can be wrong,
inducing the table display to be completely broken.

For gitweb to cope with that in a more robust manner, we can
drop the "rowspan" argument to the first <td> containing
the blame commit id, and just put empty cells instead,
whenever we have nothing to print in that column.

Signed-off-by: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
---
 gitweb/gitweb.perl |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 472326f..c760884 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -4218,7 +4218,6 @@ HTML
 		if ($group_size) {
 			print "<td class=\"sha1\"";
 			print " title=\"". esc_html($author) . ", $date\"";
-			print " rowspan=\"$group_size\"" if ($group_size > 1);
 			print ">";
 			print $cgi->a({-href => href(action=>"commit",
 			                             hash=>$full_rev,
@@ -4226,6 +4225,9 @@ HTML
 			              esc_html($rev));
 			print "</td>\n";
 		}
+		else {
+			print "<td class=\"sha1\">&nbsp;</td>";
+		}
 		open (my $dd, "-|", git_cmd(), "rev-parse", '--', "$full_rev^")
 			or die_error(undef, "Open git-rev-parse failed");
 		my $parent_commit = <$dd>;
-- 
1.5.6.rc1

  reply	other threads:[~2008-06-03 10:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03 10:14 [PATCH] Avoid git-rev-parse warnings in gitweb blame Rafael Garcia-Suarez
2008-06-03 10:14 ` Rafael Garcia-Suarez [this message]
2008-06-03 10:26 ` Rafael Garcia-Suarez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212488060-23251-2-git-send-email-rgarciasuarez@gmail.com \
    --to=rgarciasuarez@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).