From: Lea Wiemann <lewiemann@gmail.com>
To: git@vger.kernel.org
Cc: Lea Wiemann <LeWiemann@gmail.com>
Subject: [PATCH v2] t/.gitattributes: only ignore whitespace errors in test files
Date: Fri, 13 Jun 2008 09:49:33 +0200 [thread overview]
Message-ID: <1213343373-24104-1-git-send-email-LeWiemann@gmail.com> (raw)
In-Reply-To: <20080613060629.GC26768@sigill.intra.peff.net>
Only ignore whitespace errors in t/tNNNN-*.sh and the t/tNNNN
subdirectories (since they can contain test-relevant trailing
whitespace). Other files (like test libraries) should still be
checked.
Also fix a whitespace error in t/test-lib.sh.
Signed-off-by: Lea Wiemann <LeWiemann@gmail.com>
---
Jeff King wrote:
> What is the difference between test-lib.sh and tNNNN-*.sh that makes one
> subject to whitespace checking and the other not?
I thought that was obvious since they had been not been checked before
either (see the diff). :) Anyways, added explanation in parens in the
commit message; nothing else has changed since v1.
t/.gitattributes | 3 ++-
t/test-lib.sh | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/.gitattributes b/t/.gitattributes
index 562b12e..ab6edbf 100644
--- a/t/.gitattributes
+++ b/t/.gitattributes
@@ -1 +1,2 @@
-* -whitespace
+t[0-9][0-9][0-9][0-9]-*.sh -whitespace
+t[0-9][0-9][0-9][0-9]/* -whitespace
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 7a8bd27..e9c9081 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -168,7 +168,7 @@ trap 'die' exit
# environment variables to work around this.
#
# In particular, quoting isn't enough, as the path may contain the same quote
-# that we're using.
+# that we're using.
test_set_editor () {
FAKE_EDITOR="$1"
export FAKE_EDITOR
--
1.5.6.rc2.33.g0b5e3.dirty
next prev parent reply other threads:[~2008-06-13 9:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 22:35 [PATCH] t/.gitattributes: only ignore whitespace errors in test files Lea Wiemann
2008-06-13 6:06 ` Jeff King
2008-06-13 7:49 ` Lea Wiemann [this message]
2008-06-13 10:00 ` Junio C Hamano
2008-06-14 6:48 ` Jeff King
2008-06-14 6:51 ` [PATCH 1/4] fix whitespace violations in test scripts Jeff King
2008-06-14 7:01 ` Jeff King
2008-06-14 7:20 ` Junio C Hamano
2008-06-14 7:22 ` Jeff King
2008-06-14 7:25 ` [PATCH v2 1/5] " Jeff King
2008-06-14 7:26 ` [PATCH v2 2/5] mask necessary whitespace policy " Jeff King
2008-06-14 7:27 ` [PATCH v2 3/5] avoid whitespace on empty line in automatic usage message Jeff King
2008-06-14 7:27 ` [PATCH v2 4/5] avoid trailing whitespace in zero-change diffstat lines Jeff King
2008-06-14 7:28 ` [PATCH v2 5/5] enable whitespace checking of test scripts Jeff King
2008-06-14 6:54 ` [PATCH 2/4] mask necessary whitespace policy violations in " Jeff King
2008-06-14 6:56 ` [PATCH 3/4] avoid trailing whitespace in zero-change diffstat lines Jeff King
2008-06-14 7:22 ` Junio C Hamano
2008-06-14 7:30 ` Jeff King
2008-06-14 6:56 ` [PATCH 4/4] enable whitespace checking of test scripts Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213343373-24104-1-git-send-email-LeWiemann@gmail.com \
--to=lewiemann@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).