From: Mark Levedahl <mlevedahl@gmail.com>
To: paulus@samba.org
Cc: git@vger.kernel.org, Mark Levedahl <mlevedahl@gmail.com>
Subject: [PATCH] gitk - work around stderr redirection on Cygwin
Date: Sat, 14 Jun 2008 12:57:48 -0400 [thread overview]
Message-ID: <1213462668-424-1-git-send-email-mlevedahl@gmail.com> (raw)
Cygwin is *still* shipping with antiquated Tcl 8.4.1, and will continue
to do so for the indefinite future. This version does not understand
the "2>@1" redirection syntax, so such redirection of stderr must be
done using sh.
Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---
gitk | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gitk b/gitk
index fddcb45..386a385 100755
--- a/gitk
+++ b/gitk
@@ -7625,7 +7625,7 @@ proc resethead {} {
tkwait window $w
if {!$confirm_ok} return
if {[catch {set fd [open \
- [list | git reset --$resettype $rowmenuid 2>@1] r]} err]} {
+ [list | sh -c "git reset --$resettype $rowmenuid 2>&1"] r]} err]} {
error_popup $err
} else {
dohidelocalchanges
@@ -7691,7 +7691,7 @@ proc cobranch {} {
update
dohidelocalchanges
if {[catch {
- set fd [open [list | git checkout $headmenuhead 2>@1] r]
+ set fd [open [list | sh -c "git checkout $headmenuhead 2>&1"] r]
} err]} {
notbusy checkout
error_popup $err
--
1.5.6.rc2.67.g19fe3
next reply other threads:[~2008-06-14 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-14 16:57 Mark Levedahl [this message]
2008-07-13 20:37 ` [PATCH] gitk - work around stderr redirection on Cygwin Mark Levedahl
2008-07-13 21:35 ` Junio C Hamano
2008-07-13 21:53 ` Mark Levedahl
2008-07-17 3:55 ` Eric Blake
2008-07-18 2:41 ` Mark Levedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213462668-424-1-git-send-email-mlevedahl@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).