From: Pierre Habouzit <madcoder@debian.org>
To: git@vger.kernel.org
Cc: gitster@pobox.com, joerg@debian.org,
Pierre Habouzit <madcoder@debian.org>
Subject: [PATCH] Make git reflog expire honour core.sharedRepository.
Date: Sun, 15 Jun 2008 23:37:42 +0200 [thread overview]
Message-ID: <1213565862-23247-1-git-send-email-madcoder@debian.org> (raw)
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---
builtin-reflog.c | 1 +
t/t1301-shared-repo.sh | 15 +++++++++++++++
2 files changed, 16 insertions(+), 0 deletions(-)
Some people like to have logAllRefUpdates even for bare repositories, and if
shared, git-gc breaks them.
diff --git a/builtin-reflog.c b/builtin-reflog.c
index 897d1dc..430929f 100644
--- a/builtin-reflog.c
+++ b/builtin-reflog.c
@@ -308,6 +308,7 @@ static int expire_reflog(const char *ref, const unsigned char *sha1, int unused,
} else if (cmd->updateref && commit_ref(lock)) {
status |= error("Couldn't set %s", lock->ref_name);
}
+ adjust_shared_perm(log_file);
}
free(newlog_path);
free(log_file);
diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
index 5e4252a..6c78c8b 100755
--- a/t/t1301-shared-repo.sh
+++ b/t/t1301-shared-repo.sh
@@ -83,4 +83,19 @@ do
done
+test_expect_success 'git reflog expire honors core.sharedRepository' '
+ git config core.sharedRepository group &&
+ git reflog expire --all &&
+ actual="$(ls -l .git/logs/refs/heads/master)" &&
+ case "$actual" in
+ -rw-rw-*)
+ : happy
+ ;;
+ *)
+ echo Ooops, .git/logs/refs/heads/master is not 0662 [$actual]
+ false
+ ;;
+ esac
+'
+
test_done
--
1.5.6.rc3.149.gaacb0.dirty
next reply other threads:[~2008-06-15 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 21:37 Pierre Habouzit [this message]
2008-06-15 22:47 ` [PATCH] Make git reflog expire honour core.sharedRepository Junio C Hamano
2008-06-15 22:55 ` Pierre Habouzit
2008-06-16 15:15 ` Johannes Schindelin
2008-06-16 15:19 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213565862-23247-1-git-send-email-madcoder@debian.org \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=joerg@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox