From: Lea Wiemann <lewiemann@gmail.com>
To: git@vger.kernel.org
Cc: Lea Wiemann <LeWiemann@gmail.com>
Subject: [PATCH] gitweb: fix support for repository directories with spaces
Date: Tue, 17 Jun 2008 03:09:37 +0200 [thread overview]
Message-ID: <1213664977-23964-1-git-send-email-LeWiemann@gmail.com> (raw)
git_cmd_str does not quote the directory names without this patch.
Signed-off-by: Lea Wiemann <LeWiemann@gmail.com>
---
git_cmd_str is really really bad from a security POV: Where it is
used, command lines are passed to the shell, which (I believe) just
*happen* to open no security holes. Hence the function should
ultimately go away. However, let's make the tests work for the
meantime while it's still there.
gitweb/gitweb.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 07e64da..0bddc31 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1502,7 +1502,7 @@ sub git_cmd {
# returns path to the core git executable and the --git-dir parameter as string
sub git_cmd_str {
- return join(' ', git_cmd());
+ return join ' ', map("'$_'", git_cmd());
}
# get HEAD ref of given project as hash
--
1.5.6.rc3.7.ged9620
next reply other threads:[~2008-06-17 1:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 1:09 Lea Wiemann [this message]
2008-06-17 1:14 ` [PATCH] gitweb: fix support for repository directories with spaces Junio C Hamano
2008-06-17 21:27 ` Junio C Hamano
2008-06-17 21:46 ` [PATCH v2] gitweb: quote commands properly when calling the shell Lea Wiemann
2008-06-17 21:51 ` Lea Wiemann
2008-06-17 23:41 ` Junio C Hamano
2008-06-17 1:38 ` [PATCH] gitweb: fix support for repository directories with spaces Jakub Narebski
2008-06-17 22:07 ` Lea Wiemann
2008-06-17 22:27 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213664977-23964-1-git-send-email-LeWiemann@gmail.com \
--to=lewiemann@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).