From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Lea Wiemann <LeWiemann@gmail.com>,
Jakub Narebski <jnareb@gmail.com>
Subject: [PATCH] Skip Perl interface (Git.pm) tests if requirements not fullfilled
Date: Sun, 29 Jun 2008 22:32:40 +0200 [thread overview]
Message-ID: <1214771560-14005-1-git-send-email-jnareb@gmail.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0806291241210.27776@hp.linux-foundation.org>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Linus Torvalds wrote:
> Wouldn't it be a lot more polite to just not run the test when the
> Test::More stuff doesn't exist? Rather than failing the testsuite? From a
> quick "git grep", this test is the only one that uses Test::More...
Would this be enough?
t/t9700-perl-git.sh | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/t/t9700-perl-git.sh b/t/t9700-perl-git.sh
index b2fb9ec..81ff84d 100755
--- a/t/t9700-perl-git.sh
+++ b/t/t9700-perl-git.sh
@@ -6,6 +6,18 @@
test_description='perl interface (Git.pm)'
. ./test-lib.sh
+perl -MTest::More -e '' >/dev/null 2>&1 || {
+ test_expect_success 'skipping Git.pm tests, Test::More module not found' :
+ test_done
+ exit
+}
+
+perl -e 'use 5.006002;' >/dev/null 2>&1 || {
+ test_expect_success 'skipping Git.pm tests, Perl version too old' :
+ test_done
+ exit
+}
+
# set up test repository
test_expect_success \
--
1.5.6
next prev parent reply other threads:[~2008-06-29 20:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-29 19:52 perl t9700 failures? Linus Torvalds
2008-06-29 20:18 ` Junio C Hamano
2008-06-30 1:17 ` Linus Torvalds
2008-06-29 20:23 ` Junio C Hamano
2008-06-29 22:53 ` Jakub Narebski
2008-06-29 22:56 ` Lea Wiemann
2008-06-30 6:11 ` Johannes Sixt
2008-06-29 20:32 ` Jakub Narebski [this message]
2008-06-29 21:55 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214771560-14005-1-git-send-email-jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=LeWiemann@gmail.com \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).