From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>,
Marek Zawirski <marek.zawirski@gmail.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 4/8] Shorten progress message text from PackWriter
Date: Mon, 30 Jun 2008 23:04:01 -0400 [thread overview]
Message-ID: <1214881445-3931-5-git-send-email-spearce@spearce.org> (raw)
In-Reply-To: <1214881445-3931-4-git-send-email-spearce@spearce.org>
There are traditionally three phases to a pack algorithm:
the enumeration phase, commonly called "Counting objects"
the delta search phase, commonly called "Compressing objects"
the output phase, commonly called "Writing objects"
Our prior messages were too long for the text progress display
and caused the progress meters to not line up vertically on the
console. The shorter (and more traditional) text does fit into
the column structure used by the text progress display.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
.../src/org/spearce/jgit/lib/PackWriter.java | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/PackWriter.java b/org.spearce.jgit/src/org/spearce/jgit/lib/PackWriter.java
index 9a427da..0439656 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/PackWriter.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/PackWriter.java
@@ -102,7 +102,7 @@ public class PackWriter {
*
* @see #preparePack(Collection, Collection, boolean, boolean)
*/
- public static final String COUNTING_OBJECTS_PROGRESS = "Counting objects to pack";
+ public static final String COUNTING_OBJECTS_PROGRESS = "Counting objects";
/**
* Title of {@link ProgressMonitor} task used during searching for objects
@@ -110,7 +110,7 @@ public class PackWriter {
*
* @see #writePack(OutputStream)
*/
- public static final String SEARCHING_REUSE_PROGRESS = "Searching for delta and object reuse";
+ public static final String SEARCHING_REUSE_PROGRESS = "Compressing objects";
/**
* Title of {@link ProgressMonitor} task used during writing out pack
--
1.5.6.74.g8a5e
next prev parent reply other threads:[~2008-07-01 3:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 3:03 [JGIT PATCH 0/8] Minor push fixups Shawn O. Pearce
2008-07-01 3:03 ` [JGIT PATCH 1/8] Correct thin pack completion in IndexPack to handle some bundles Shawn O. Pearce
2008-07-01 3:03 ` [JGIT PATCH 2/8] Delete reflog when deleting ref during dumb transport push Shawn O. Pearce
2008-07-01 3:04 ` [JGIT PATCH 3/8] Refuse to create or delete funny ref names over dumb transports Shawn O. Pearce
2008-07-01 3:04 ` Shawn O. Pearce [this message]
2008-07-01 3:04 ` [JGIT PATCH 5/8] Correctly name the stderr redirection thread for local transport Shawn O. Pearce
2008-07-01 3:04 ` [JGIT PATCH 6/8] Support 'git upload-pack' and 'git receive-pack' over SSH Shawn O. Pearce
2008-07-01 3:04 ` [JGIT PATCH 7/8] Pack jgit into a portable single file command line utility Shawn O. Pearce
2008-07-01 3:04 ` [JGIT PATCH 8/8] Don't try to pack 0{40} during push of delete and update Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214881445-3931-5-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=marek.zawirski@gmail.com \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).