git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Beyer <s-beyer@gmx.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Dmitry Potapov <dpotapov@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org, Stephan Beyer <s-beyer@gmx.net>
Subject: [PATCH] Remove function stubs in shell.c
Date: Fri, 18 Jul 2008 03:06:37 +0200	[thread overview]
Message-ID: <1216343197-20290-1-git-send-email-s-beyer@gmx.net> (raw)
In-Reply-To: <20080718005814.GA4155@spearce.org>

These function stubs may be useful, but because they redefine
functions, they provoke a linker error.

Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
Or would you rather like this one? ;)

 shell.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/shell.c b/shell.c
index 91ca7de..b27d01c 100644
--- a/shell.c
+++ b/shell.c
@@ -3,14 +3,6 @@
 #include "exec_cmd.h"
 #include "strbuf.h"
 
-/* Stubs for functions that make no sense for git-shell. These stubs
- * are provided here to avoid linking in external redundant modules.
- */
-void release_pack_memory(size_t need, int fd){}
-void trace_argv_printf(const char **argv, const char *fmt, ...){}
-void trace_printf(const char *fmt, ...){}
-
-
 static int do_generic_cmd(const char *me, char *arg)
 {
 	const char *my_argv[4];
-- 
1.5.6.3.390.g7b30

  parent reply	other threads:[~2008-07-18  1:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-27 21:35 [PATCH] shrink git-shell by avoiding redundant dependencies Dmitry Potapov
2008-06-27 21:55 ` Junio C Hamano
2008-06-27 22:31   ` Dmitry Potapov
2008-06-27 22:34     ` Junio C Hamano
2008-07-18  0:26     ` Stephan Beyer
2008-07-18  0:58       ` Shawn O. Pearce
2008-07-18  1:04         ` [PATCH] Link git-shell only to a subset of libgit.a Stephan Beyer
2008-07-18  1:06           ` Shawn O. Pearce
2008-07-18  6:03           ` Dmitry Potapov
2008-07-18 10:55             ` Johannes Schindelin
2008-07-18  1:06         ` Stephan Beyer [this message]
2008-07-18  6:06           ` [PATCH] Remove function stubs in shell.c Dmitry Potapov
2008-07-18  5:59       ` [PATCH] shrink git-shell by avoiding redundant dependencies Dmitry Potapov
2008-06-28 14:51 ` Johannes Schindelin
2008-06-28 16:48   ` Dmitry Potapov
2008-06-28 17:31     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216343197-20290-1-git-send-email-s-beyer@gmx.net \
    --to=s-beyer@gmx.net \
    --cc=dpotapov@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).