From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>,
Marek Zawirski <marek.zawirski@gmail.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 08/28] Add parseTree method to RevWalk to obtain a RevTree from AnyObjectId
Date: Thu, 17 Jul 2008 21:44:01 -0400 [thread overview]
Message-ID: <1216345461-59382-9-git-send-email-spearce@spearce.org> (raw)
In-Reply-To: <1216345461-59382-8-git-send-email-spearce@spearce.org>
Some applications want to dereference an ObjectId back to a tree,
and they don't care what type of object the ObjectId supplied is
actually of. If its an annotated tag we can peel the tag back to
either a tree, or a commit, and a commit can be peeled back to its
only tree. So parseTree is a simple API for ^{tree}.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
.../src/org/spearce/jgit/revwalk/RevWalk.java | 35 ++++++++++++++++++++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/revwalk/RevWalk.java b/org.spearce.jgit/src/org/spearce/jgit/revwalk/RevWalk.java
index 946486c..42ec2a2 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/revwalk/RevWalk.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/revwalk/RevWalk.java
@@ -612,6 +612,41 @@ public class RevWalk implements Iterable<RevCommit> {
}
/**
+ * Locate a reference to a tree.
+ * <p>
+ * This method only returns successfully if the tree object exists, is
+ * verified to be a tree, and was parsed without error.
+ *
+ * @param id
+ * name of the tree object, or a commit or annotated tag that may
+ * reference a tree.
+ * @return reference to the tree object. Never null.
+ * @throws MissingObjectException
+ * the supplied tree does not exist.
+ * @throws IncorrectObjectTypeException
+ * the supplied id is not a tree, a commit or an annotated tag.
+ * @throws IOException
+ * a pack file or loose object could not be read.
+ */
+ public RevTree parseTree(final AnyObjectId id)
+ throws MissingObjectException, IncorrectObjectTypeException,
+ IOException {
+ RevObject c = parseAny(id);
+ while (c instanceof RevTag) {
+ c = ((RevTag) c).getObject();
+ parse(c);
+ }
+ if (c instanceof RevCommit) {
+ c = ((RevCommit) c).getTree();
+ parse(c);
+ }
+ final RevTree t = (RevTree) c;
+ if (db.openObject(t).getType() != Constants.OBJ_TREE)
+ throw new IncorrectObjectTypeException(t, Constants.TYPE_TREE);
+ return t;
+ }
+
+ /**
* Locate a reference to any object and immediately parse its content.
* <p>
* This method only returns successfully if the object exists and was parsed
--
1.5.6.3.569.ga9185
next prev parent reply other threads:[~2008-07-18 1:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 1:43 [JGIT PATCH 00/28] Convert command line parsing to args4j Shawn O. Pearce
2008-07-18 1:43 ` [JGIT PATCH 01/28] Fix deadlock caused by push over SSH Shawn O. Pearce
2008-07-18 1:43 ` [JGIT PATCH 02/28] Use die utility method in glog Shawn O. Pearce
2008-07-18 1:43 ` [JGIT PATCH 03/28] Add args4j library for command line switch processing Shawn O. Pearce
2008-07-18 1:43 ` [JGIT PATCH 04/28] Move org.spearce.jgit.pgm to its own Java project Shawn O. Pearce
2008-07-18 1:43 ` [JGIT PATCH 05/28] Make TextBuiltin public so other packages can implement and use it Shawn O. Pearce
2008-07-18 1:43 ` [JGIT PATCH 06/28] Initialize TextBuiltins with the repository before execution Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 07/28] Define our own extended CmdLineParser for extra parsing support Shawn O. Pearce
2008-07-18 1:44 ` Shawn O. Pearce [this message]
2008-07-18 1:44 ` [JGIT PATCH 09/28] Add option handler for AbstractTreeIterator values Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 10/28] Add option handler for ObjectId values Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 11/28] Add option handler for PathTreeFilter values Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 12/28] Add option handler for RefSpec values Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 13/28] Add option handler for RevCommit values Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 14/28] Add option handler for RevTree values Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 15/28] Register most of our OptionHandler implementations for automatic use Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 16/28] Convert jgit's Main to use args4j for basic parsing services Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 17/28] Support automatic command line parsing for TextBuiltin subclasses Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 18/28] Convert diff-tree program to args4j Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 19/28] Convert fetch " Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 20/28] Convert index-pack " Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 21/28] Convert ls-remote " Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 22/28] Convert ls-tree " Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 23/28] Convert merge-base " Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 24/28] Convert push " Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 25/28] Convert show-ref " Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 26/28] Convert tag " Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 27/28] Convert rev-list, log, glog programs " Shawn O. Pearce
2008-07-18 1:44 ` [JGIT PATCH 28/28] Remove support for legacy style TextBuiltins Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216345461-59382-9-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=marek.zawirski@gmail.com \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).