git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Enable threaded delta search on *BSD and Linux.
@ 2008-07-21  9:23 Pierre Habouzit
  2008-07-22  4:54 ` Junio C Hamano
  0 siblings, 1 reply; 3+ messages in thread
From: Pierre Habouzit @ 2008-07-21  9:23 UTC (permalink / raw)
  To: git; +Cc: gitster, Pierre Habouzit

Signed-off-by: Pierre Habouzit <madcoder@debian.org>
---

  Following the discussion we had 10 days ago, here is a proposal to enable
  threaded delta search on systems that are likely to behave properly wrt
  memory and CPU usage.

 Makefile |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index 551bde9..82f89b7 100644
--- a/Makefile
+++ b/Makefile
@@ -565,9 +565,11 @@ EXTLIBS =
 
 ifeq ($(uname_S),Linux)
 	NO_STRLCPY = YesPlease
+	THREADED_DELTA_SEARCH = YesPlease
 endif
 ifeq ($(uname_S),GNU/kFreeBSD)
 	NO_STRLCPY = YesPlease
+	THREADED_DELTA_SEARCH = YesPlease
 endif
 ifeq ($(uname_S),UnixWare)
 	CC = cc
@@ -665,6 +667,7 @@ ifeq ($(uname_S),FreeBSD)
 	BASIC_CFLAGS += -I/usr/local/include
 	BASIC_LDFLAGS += -L/usr/local/lib
 	DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease
+	THREADED_DELTA_SEARCH = YesPlease
 endif
 ifeq ($(uname_S),OpenBSD)
 	NO_STRCASESTR = YesPlease
@@ -672,6 +675,7 @@ ifeq ($(uname_S),OpenBSD)
 	NEEDS_LIBICONV = YesPlease
 	BASIC_CFLAGS += -I/usr/local/include
 	BASIC_LDFLAGS += -L/usr/local/lib
+	THREADED_DELTA_SEARCH = YesPlease
 endif
 ifeq ($(uname_S),NetBSD)
 	ifeq ($(shell expr "$(uname_R)" : '[01]\.'),2)
@@ -680,6 +684,7 @@ ifeq ($(uname_S),NetBSD)
 	BASIC_CFLAGS += -I/usr/pkg/include
 	BASIC_LDFLAGS += -L/usr/pkg/lib
 	ALL_LDFLAGS += -Wl,-rpath,/usr/pkg/lib
+	THREADED_DELTA_SEARCH = YesPlease
 endif
 ifeq ($(uname_S),AIX)
 	NO_STRCASESTR=YesPlease
-- 
1.6.0.rc0.137.g986dd

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Enable threaded delta search on *BSD and Linux.
  2008-07-21  9:23 [PATCH] Enable threaded delta search on *BSD and Linux Pierre Habouzit
@ 2008-07-22  4:54 ` Junio C Hamano
  2008-07-22  6:51   ` Pierre Habouzit
  0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2008-07-22  4:54 UTC (permalink / raw)
  To: Pierre Habouzit; +Cc: git

Pierre Habouzit <madcoder@debian.org> writes:

> Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> ---
>
>   Following the discussion we had 10 days ago, here is a proposal to enable
>   threaded delta search on systems that are likely to behave properly wrt
>   memory and CPU usage.

Hmmm.

I do not want to do this kind of thing very close to the release (like
now), but rather immediately after 1.6.0.  Will queue for 'next'.

Distro people can decide for themselves and their users, but I am of
conservative kind.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Enable threaded delta search on *BSD and Linux.
  2008-07-22  4:54 ` Junio C Hamano
@ 2008-07-22  6:51   ` Pierre Habouzit
  0 siblings, 0 replies; 3+ messages in thread
From: Pierre Habouzit @ 2008-07-22  6:51 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

On Tue, Jul 22, 2008 at 04:54:14AM +0000, Junio C Hamano wrote:
> Pierre Habouzit <madcoder@debian.org> writes:
> 
> > Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> > ---
> >
> >   Following the discussion we had 10 days ago, here is a proposal to enable
> >   threaded delta search on systems that are likely to behave properly wrt
> >   memory and CPU usage.
> 
> Hmmm.
> 
> I do not want to do this kind of thing very close to the release (like
> now), but rather immediately after 1.6.0.  Will queue for 'next'.
> 
> Distro people can decide for themselves and their users, but I am of
> conservative kind.

  makes sense to me.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-07-22  6:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-21  9:23 [PATCH] Enable threaded delta search on *BSD and Linux Pierre Habouzit
2008-07-22  4:54 ` Junio C Hamano
2008-07-22  6:51   ` Pierre Habouzit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).