Re: Gitweb: Provide Git links in project list?

["J.H." <warthog19@eaglescrag.net>]

Robert,

Noticed, but while I agree cloneurl is good - I think it kind of defeats
the purpose of what I was originally intending with the 'git' link.
I've gone back in to understand cloneurl better and I genuinely think
this is the wrong approach (or at least not what was originally intended
with the 'git' link as I envisioned it).

The git link was always meant / intended to be a link to acquire the git
repository directly, and be independent of what is actually present in
the cloneurl file, specifically I wanted it to be a (1) git url
(git://<hostname>/<path>) so that it took advantage of git specifically
vs. accidentally giving you something with ssh or http. and (2) was
uniform and did *not* depend on something in the repository as with
large set of repositories, kernel.org, there is no way we can police
this and we explicitly do not want to have a script that automatically
adds this or what not.

I have two other concerns with the patch your proposing

(1) it's on by default, and it seems that there are a number of sites
that don't actually want this functionality, making it a configurable
option would seem prudent in that case

(2) ignoring my comments on why I think using cloneurl for a large site
is bad (after I looked into it), blindly on taking the first option in
the file may lead to the display of unexpected or unintended URLs.

That said, it's probably worth merging the two patches (since I'm
already there with the configuration options, etc) that way people can
get either functionality should they choose.

- John 'Warthog9' Hawley

On Mon, 2008-08-04 at 12:12 +0200, Robert Richter wrote:
> On 03.08.08 13:53:13, J.H. wrote:
> > Working on refactoring the patch so that it can go upstream, one of the
> > things I'm definitely making an assumption about (in my original code)
> > is that the base url will be uniform for the entire project_list (as it
> > is on kernel.org).  If that's acceptable I will probably be able to
> > submit something today, if not I will need to muck about and read out
> > the url from .git/cloneurl (which would be a rather hefty performance
> > hit - needing to read that from each repository)
> 
> John,
> 
> I just sent out a patch that implements this using cloneurl. It seemed
> small and easy to implement and so I just made the change myself.
> 
> Thank you anyway.
> 
> -Robert
>