git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Kumria <wildfire@progsoc.org>
To: git@vger.kernel.org
Cc: simon@lst.de, Anand Kumria <wildfire@progsoc.org>
Subject: [PATCH 05/12]  Add a single command that will be used to construct the 'p4' command
Date: Sun, 10 Aug 2008 19:26:28 +0100	[thread overview]
Message-ID: <1218392795-4084-6-git-send-email-wildfire@progsoc.org> (raw)
In-Reply-To: <1218392795-4084-5-git-send-email-wildfire@progsoc.org>

 Rather than having three locations where the 'p4' command is built up,
 refactor this into the one place. This will, eventually, allow us to
 have one place where we modify the evironment or pass extra
 command-line options to the 'p4' binary.

Signed-off-by: Anand Kumria <wildfire@progsoc.org>
---
 contrib/fast-import/git-p4 |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index 2ed36ec..b4acf76 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -16,6 +16,17 @@ from sets import Set;
 
 verbose = False
 
+
+def p4_build_cmd(cmd):
+    """Build a suitable p4 command line.
+
+    This consolidates building and returning a p4 command line into one
+    location. It means that hooking into the environment, or other configuration
+    can be done more easily.
+    """
+    real_cmd = "%s %s" % ("p4", cmd)
+    return real_cmd
+
 def die(msg):
     if verbose:
         raise Exception(msg)
-- 
1.5.6.3

  reply	other threads:[~2008-08-10 18:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-10 18:26 [PATCH 00/12] Allow users to access Perforce repositories requiring authentication Anand Kumria
2008-08-10 18:26 ` [PATCH 01/12] Create a specific version of the read_pipe_lines command for p4 invocations Anand Kumria
2008-08-10 18:26   ` [PATCH 02/12] Utilise the new 'p4_read_pipe_lines' command Anand Kumria
2008-08-10 18:26     ` [PATCH 03/12] Have a command that specifically invokes 'p4' (via system) Anand Kumria
2008-08-10 18:26       ` [PATCH 04/12] Utilise the new 'p4_system' function Anand Kumria
2008-08-10 18:26         ` Anand Kumria [this message]
2008-08-10 18:26           ` [PATCH 06/12] If we are in verbose mode, output what we are about to run (or return) Anand Kumria
2008-08-10 18:26             ` [PATCH 07/12] Switch to using 'p4_build_cmd' Anand Kumria
2008-08-10 18:26               ` [PATCH 08/12] If the user has configured various parameters, use them Anand Kumria
2008-08-10 18:26                 ` [PATCH 09/12] Consistently use 'git-p4' for the configuration entries Anand Kumria
2008-08-10 18:26                   ` [PATCH 10/12] Move git-p4.syncFromOrigin into a configuration parameters section Anand Kumria
2008-08-10 18:26                     ` [PATCH 11/12] Put some documentation in about the parameters that have been added Anand Kumria
2008-08-10 18:26                       ` [PATCH 12/12] Put in the two other configuration elements found in the source Anand Kumria
2008-08-13 19:47 ` [PATCH 00/12] Allow users to access Perforce repositories requiring authentication Simon Hausmann
2008-08-14 17:00 ` Tor Arvid Lund
2008-08-14 22:01   ` Anand Kumria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218392795-4084-6-git-send-email-wildfire@progsoc.org \
    --to=wildfire@progsoc.org \
    --cc=git@vger.kernel.org \
    --cc=simon@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).