From: Charles O'Farrell <charleso@charleso.org>
To: git@vger.kernel.org
Cc: Charles O'Farrell <charleso@charleso.org>
Subject: [PATCH 2/7] Refactor of RefUpdate force to call common updateImpl instead of duplication
Date: Thu, 14 Aug 2008 20:13:44 +1000 [thread overview]
Message-ID: <1218708829-8175-3-git-send-email-charleso@charleso.org> (raw)
In-Reply-To: <1218708829-8175-2-git-send-email-charleso@charleso.org>
Signed-off-by: Charles O'Farrell <charleso@charleso.org>
---
.../src/org/spearce/jgit/lib/RefUpdate.java | 38 ++++---------------
1 files changed, 8 insertions(+), 30 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/RefUpdate.java b/org.spearce.jgit/src/org/spearce/jgit/lib/RefUpdate.java
index 369cb37..1b38fce 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/RefUpdate.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/RefUpdate.java
@@ -266,31 +266,8 @@ public class RefUpdate {
* an unexpected IO error occurred while writing changes.
*/
public Result forceUpdate() throws IOException {
- requireCanDoUpdate();
- try {
- return result = forceUpdateImpl();
- } catch (IOException x) {
- result = Result.IO_FAILURE;
- throw x;
- }
- }
-
- private Result forceUpdateImpl() throws IOException {
- final LockFile lock;
-
- lock = new LockFile(looseFile);
- if (!lock.lock())
- return Result.LOCK_FAILURE;
- try {
- oldValue = db.idOf(name);
- if (oldValue == null)
- return store(lock, Result.NEW);
- if (oldValue.equals(newValue))
- return Result.NO_CHANGE;
- return store(lock, Result.FORCED);
- } finally {
- lock.unlock();
- }
+ force = true;
+ return update();
}
/**
@@ -347,6 +324,12 @@ public class RefUpdate {
if (oldValue == null)
return store(lock, Result.NEW);
+ if (isForceUpdate()) {
+ if (oldValue.equals(newValue))
+ return Result.NO_CHANGE;
+ return store(lock, Result.FORCED);
+ }
+
newObj = walk.parseAny(newValue);
oldObj = walk.parseAny(oldValue);
if (newObj == oldObj)
@@ -355,13 +338,8 @@ public class RefUpdate {
if (newObj instanceof RevCommit && oldObj instanceof RevCommit) {
if (walk.isMergedInto((RevCommit) oldObj, (RevCommit) newObj))
return store(lock, Result.FAST_FORWARD);
- if (isForceUpdate())
- return store(lock, Result.FORCED);
- return Result.REJECTED;
}
- if (isForceUpdate())
- return store(lock, Result.FORCED);
return Result.REJECTED;
} finally {
lock.unlock();
--
1.6.0.rc2.35.g04c6e
next prev parent reply other threads:[~2008-08-14 10:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 10:13 [PATCH 0/7] jgit: Branch command now supports deletion Charles O'Farrell
2008-08-14 10:13 ` [PATCH 1/7] Refactor of WalkRemoteObjectDatabase ref writing into common class Charles O'Farrell
2008-08-14 10:13 ` Charles O'Farrell [this message]
2008-08-14 10:13 ` [PATCH 3/7] Minor refactor of constants, including log and ROOT_DIR Charles O'Farrell
2008-08-14 10:13 ` [PATCH 4/7] Extract lockAndWriteFile method in RefDatabase for reuse Charles O'Farrell
2008-08-14 10:13 ` [PATCH 5/7] Added removePackedRef method to RefDatabase for packed branch deletion Charles O'Farrell
2008-08-14 10:13 ` [PATCH 6/7] Added ref deletion to RefUpdate Charles O'Farrell
2008-08-14 10:13 ` [PATCH 7/7] jgit: Added branch deletion to jgit command Charles O'Farrell
2008-08-14 22:23 ` [PATCH 2/7] Refactor of RefUpdate force to call common updateImpl instead of duplication Shawn O. Pearce
2008-08-15 0:25 ` [JGIT PATCH v2 " Charles O'Farrell
2008-08-15 0:25 ` [JGIT PATCH v2 6/7] Added ref deletion to RefUpdate Charles O'Farrell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218708829-8175-3-git-send-email-charleso@charleso.org \
--to=charleso@charleso.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).