From: Anand Kumria <wildfire@progsoc.org>
To: git@vger.kernel.org
Cc: simon@lst.de, torarvid@gmail.com, Anand Kumria <wildfire@progsoc.org>
Subject: [PATCH 2/2] Utilise our new p4_read_pipe and p4_write_pipe wrappers
Date: Thu, 14 Aug 2008 23:40:39 +0100 [thread overview]
Message-ID: <1218753639-32716-2-git-send-email-wildfire@progsoc.org> (raw)
In-Reply-To: <1218753639-32716-1-git-send-email-wildfire@progsoc.org>
In-Reply-To: <g829vo@ger.gmane.org>
Signed-off-by: Anand Kumria <wildfire@progsoc.org>
---
contrib/fast-import/git-p4 | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index 3e9df70..12fa9d3 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -141,7 +141,7 @@ def setP4ExecBit(file, mode):
def getP4OpenedType(file):
# Returns the perforce file type for the given file.
- result = read_pipe("p4 opened %s" % file)
+ result = p4_read_pipe("opened %s" % file)
match = re.match(".*\((.+)\)\r?$", result)
if match:
return match.group(1)
@@ -681,7 +681,7 @@ class P4Submit(Command):
submitTemplate = self.prepareLogMessage(template, logMessage)
if os.environ.has_key("P4DIFF"):
del(os.environ["P4DIFF"])
- diff = read_pipe("p4 diff -du ...")
+ diff = p4_read_pipe("diff -du ...")
newdiff = ""
for newFile in filesToAdd:
@@ -719,7 +719,7 @@ class P4Submit(Command):
if self.isWindows:
submitTemplate = submitTemplate.replace("\r\n", "\n")
- write_pipe("p4 submit -i", submitTemplate)
+ p4_write_pipe("submit -i", submitTemplate)
else:
fileName = "submit.txt"
file = open(fileName, "w+")
--
1.5.6.3
prev parent reply other threads:[~2008-08-14 22:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <g829vo@ger.gmane.org>
2008-08-14 22:40 ` [PATCH 1/2] Add p4 read_pipe and write_pipe wrappers Anand Kumria
2008-08-14 22:40 ` Anand Kumria [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218753639-32716-2-git-send-email-wildfire@progsoc.org \
--to=wildfire@progsoc.org \
--cc=git@vger.kernel.org \
--cc=simon@lst.de \
--cc=torarvid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).