* [JGIT PATCH] Paper bag fix 'jgit glog' handling of commit-ish arguments
@ 2008-08-14 23:26 Shawn O. Pearce
0 siblings, 0 replies; only message in thread
From: Shawn O. Pearce @ 2008-08-14 23:26 UTC (permalink / raw)
To: Robin Rosenberg; +Cc: git
When we parsed these arguments into RevCommit instances they were
done against the wrong RevWalk instance. We parsed them into a
generic RevWalk which has no plotting support, so the objects do
not have the extra fields used by the plotting code. We need to
lookup the commit from the PlotRevWalk and use those instances.
One of the calls (markStart) failed to use the secondary RevWalk
instance, resulting in a ClassCastException during plotting.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
.../org/spearce/jgit/pgm/RevWalkTextBuiltin.java | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java
index 97fe7a4..338af40 100644
--- a/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java
+++ b/org.spearce.jgit.pgm/src/org/spearce/jgit/pgm/RevWalkTextBuiltin.java
@@ -152,7 +152,7 @@ abstract class RevWalkTextBuiltin extends TextBuiltin {
if (c.has(RevFlag.UNINTERESTING))
walk.markUninteresting(real);
else
- walk.markStart(c);
+ walk.markStart(real);
}
final long start = System.currentTimeMillis();
--
1.6.0.rc3.250.g8dd0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2008-08-14 23:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-14 23:26 [JGIT PATCH] Paper bag fix 'jgit glog' handling of commit-ish arguments Shawn O. Pearce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).