From: Stephan Beyer <s-beyer@gmx.net>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Stephan Beyer <s-beyer@gmx.net>
Subject: [PATCH] Improve error output of git-rebase without any arguments
Date: Sun, 17 Aug 2008 02:26:21 +0200 [thread overview]
Message-ID: <1218932781-30475-1-git-send-email-s-beyer@gmx.net> (raw)
"git rebase" without arguments on initial startup showed:
fatal: Needed a single revision
invalid upstream
This patch makes it show the ordinary usage string.
For the case that .git/rebase-{apply,merge} exists,
A rebase is in progress, try --continue, --skip or --abort.
is shown now.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
---
Stumbled across this today and looks for me like
a patch for 1.6.0 :-)
git-rebase.sh | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/git-rebase.sh b/git-rebase.sh
index 412e135..fe669ad 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -146,6 +146,12 @@ is_interactive () {
is_interactive "$@" && exec git-rebase--interactive "$@"
+if test $# -eq 0
+then
+ test -d "$dotest" -o -d "$GIT_DIR"/rebase-apply || usage
+ die 'A rebase is in progress, try --continue, --skip or --abort.'
+fi
+
while test $# != 0
do
case "$1" in
@@ -277,7 +283,7 @@ It seems that I cannot create a '"$GIT_DIR"'/rebase-apply directory,
and I wonder if you are in the middle of patch application or another
rebase. If that is not the case, please
rm -fr '"$GIT_DIR"'/rebase-apply
- and run me again. I am stopping in case you still have something
+and run me again. I am stopping in case you still have something
valuable there.'
exit 1
fi
--
1.6.0.rc3.308.g5b83
next reply other threads:[~2008-08-17 0:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 0:26 Stephan Beyer [this message]
2008-08-17 2:37 ` [PATCH] Improve error output of git-rebase without any arguments Junio C Hamano
2008-08-17 4:05 ` [PATCH try2] Improve error output of git-rebase Stephan Beyer
2008-08-17 4:11 ` Stephan Beyer
2008-08-17 4:25 ` [PATCH try3] " Stephan Beyer
2008-08-17 5:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218932781-30475-1-git-send-email-s-beyer@gmx.net \
--to=s-beyer@gmx.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox