Git development
 help / color / mirror / Atom feed
From: Jan Nieuwenhuizen <janneke-list@xs4all.nl>
To: Jonathan Nieder <jrnieder@uchicago.edu>
Cc: git <git@vger.kernel.org>, Jan Holesovsky <kendy@suse.cz>
Subject: Re: [TopGit PATCH] tg redepend: New command.
Date: Mon, 18 Aug 2008 11:23:28 +0200	[thread overview]
Message-ID: <1219051408.8816.34.camel@heerbeest> (raw)
In-Reply-To: <Pine.GSO.4.62.0808151241300.17250@harper.uchicago.edu>

On vr, 2008-08-15 at 13:20 -0500, Jonathan Nieder wrote:

Hi,

> s/tg/tg redepend/?

Yes.

> Why not move the base-creation code in tg-create.sh to a new
> function in tg.sh to use here?

Yes, that's better.
 
> I know I suggested that code before, but the merge with B' is wasted, so
> perhaps
> 
> 	git checkout P
> 	head=$(git rev-parse --verify HEAD^0)
> 	result_tree=$(git log -1 --pretty=format:%T P')
> 	result_commit=$(git commit-tree "$result_tree" -p P -p B')
> 	git update-ref -m "commit (merge): tg-redepend" HEAD \
> 			"$result_commit" "$head" || ... (fail)
> 	test -x "$GIT_DIR/hooks/post-merge" && $GIT_DIR/hooks/post-merge 0
> 
> I'm not sure.  Is there some more porcelain-ish way to do this (create a
> merge commit when you already know the resulting and parents)?
> 
> But with that change the entire restarted=merge branch would go away,
> so I hope there is a nice way to do it.  I'll think more.

Yes, the user should get a nice chance to resolve any conflicts...

Thanks!
Jan.

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond - The music typesetter
http://www.xs4all.nl/~jantien       | http://www.lilypond.org

  reply	other threads:[~2008-08-18 11:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15 13:53 [TopGit PATCH] tg redepend: New command Jan Nieuwenhuizen
2008-08-15 17:16 ` Bert Wesarg
2008-08-15 18:20 ` Jonathan Nieder
2008-08-18  9:23   ` Jan Nieuwenhuizen [this message]
2008-09-01  9:31 ` Bert Wesarg
2008-09-01 10:11   ` Jan Nieuwenhuizen
2008-09-01 10:36     ` Bert Wesarg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219051408.8816.34.camel@heerbeest \
    --to=janneke-list@xs4all.nl \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@uchicago.edu \
    --cc=kendy@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox