From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: [JGIT PATCH 1/4] Simplify and micro-optimize WorkingTreeIterator.ENTRY_CMP
Date: Thu, 21 Aug 2008 13:57:35 -0700 [thread overview]
Message-ID: <1219352258-15431-1-git-send-email-spearce@spearce.org> (raw)
We already did this simplification work to AbstractTreeIterator's
pathCompare method, and this is based upon that same structure.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
.../spearce/jgit/treewalk/WorkingTreeIterator.java | 44 ++-----------------
1 files changed, 5 insertions(+), 39 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/treewalk/WorkingTreeIterator.java b/org.spearce.jgit/src/org/spearce/jgit/treewalk/WorkingTreeIterator.java
index c6664f5..6fce150 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/treewalk/WorkingTreeIterator.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/treewalk/WorkingTreeIterator.java
@@ -297,45 +297,11 @@ public int compare(final Entry o1, final Entry o2) {
return cmp;
}
- if (cPos < aLen) {
- final int aj = a[cPos] & 0xff;
- final int lastb = lastPathChar(o2);
- if (aj < lastb)
- return -1;
- else if (aj > lastb)
- return 1;
- else if (cPos == aLen - 1)
- return 0;
- else
- return -1;
- }
-
- if (cPos < bLen) {
- final int bk = b[cPos] & 0xff;
- final int lasta = lastPathChar(o1);
- if (lasta < bk)
- return -1;
- else if (lasta > bk)
- return 1;
- else if (cPos == bLen - 1)
- return 0;
- else
- return 1;
- }
-
- final int lasta = lastPathChar(o1);
- final int lastb = lastPathChar(o2);
- if (lasta < lastb)
- return -1;
- else if (lasta > lastb)
- return 1;
-
- if (aLen == bLen)
- return 0;
- else if (aLen < bLen)
- return -1;
- else
- return 1;
+ if (cPos < aLen)
+ return (a[cPos] & 0xff) - lastPathChar(o2);
+ if (cPos < bLen)
+ return lastPathChar(o1) - (b[cPos] & 0xff);
+ return lastPathChar(o1) - lastPathChar(o2);
}
};
--
1.6.0.112.g9c75
next reply other threads:[~2008-08-21 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 20:57 Shawn O. Pearce [this message]
2008-08-21 20:57 ` [JGIT PATCH 2/4] Support post order tree handling during TreeWalk Shawn O. Pearce
2008-08-21 20:57 ` [JGIT PATCH 3/4] Micro-optimize TreeWalk's exitSubtree implementation Shawn O. Pearce
2008-08-21 20:57 ` [JGIT PATCH 4/4] Add getNameString to TreeWalk to get only the last path component Shawn O. Pearce
2008-08-22 20:45 ` [JGIT PATCH 1/4] Simplify and micro-optimize WorkingTreeIterator.ENTRY_CMP Robin Rosenberg
2008-08-22 23:07 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219352258-15431-1-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).