From: Marek Zawirski <marek.zawirski@gmail.com>
To: robin.rosenberg@dewire.com, spearce@spearce.org
Cc: git@vger.kernel.org, Marek Zawirski <marek.zawirski@gmail.com>
Subject: [EGIT PATCH 2/6] Fix RefSpecPanel to not display mode column in fetch version
Date: Wed, 27 Aug 2008 20:41:42 +0200 [thread overview]
Message-ID: <1219862506-11075-3-git-send-email-marek.zawirski@gmail.com> (raw)
In-Reply-To: <1219862506-11075-2-git-send-email-marek.zawirski@gmail.com>
"Delete" mode is valid only for push, we need only "update/create"
mode for fetch, so there is no need to display this column here.
Signed-off-by: Marek Zawirski <marek.zawirski@gmail.com>
---
.../egit/ui/internal/components/RefSpecPanel.java | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/components/RefSpecPanel.java b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/components/RefSpecPanel.java
index 34d37fd..de82480 100644
--- a/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/components/RefSpecPanel.java
+++ b/org.spearce.egit.ui/src/org/spearce/egit/ui/internal/components/RefSpecPanel.java
@@ -951,7 +951,8 @@ private void createTableColumns(final Composite tablePanel) {
tablePanel.setLayout(columnLayout);
createDummyColumn(columnLayout);
- createModeColumn(columnLayout);
+ if (pushSpecs)
+ createModeColumn(columnLayout);
createSrcColumn(columnLayout);
createDstColumn(columnLayout);
createForceColumn(columnLayout);
@@ -1277,7 +1278,8 @@ private TableViewerColumn createColumn(
}
private void createCellEditors(final Table table) {
- modeCellEditor = new CheckboxCellEditor(table);
+ if (pushSpecs)
+ modeCellEditor = new CheckboxCellEditor(table);
localRefCellEditor = createLocalRefCellEditor(table);
remoteRefCellEditor = createRemoteRefCellEditor(table);
forceUpdateCellEditor = new CheckboxCellEditor(table);
--
1.5.6.3
next prev parent reply other threads:[~2008-08-27 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 18:41 [EGIT PATCH 0/6] Fetch UI, minor improvements/fixes Marek Zawirski
2008-08-27 18:41 ` [EGIT PATCH 1/6] Reduce PushOperationResult contructor visibility, accept null instead Marek Zawirski
2008-08-27 18:41 ` Marek Zawirski [this message]
2008-08-27 18:41 ` [EGIT PATCH 3/6] Handle null remoteName in RefSpecPanel better Marek Zawirski
2008-08-27 18:41 ` [EGIT PATCH 4/6] Add tag fetching strategy selection to fetch version of RefSpecPage Marek Zawirski
2008-08-27 18:41 ` [EGIT PATCH 5/6] Rename ResultDialog to PushResultDialog Marek Zawirski
2008-08-27 18:41 ` [EGIT PATCH 6/6] Fetch GUI Marek Zawirski
2008-08-27 19:48 ` [EGIT PATCH 0/6] Fetch UI, minor improvements/fixes Robin Rosenberg
2008-08-27 20:09 ` Marek Zawirski
2008-08-27 21:51 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219862506-11075-3-git-send-email-marek.zawirski@gmail.com \
--to=marek.zawirski@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).