From: Marek Zawirski <marek.zawirski@gmail.com>
To: robin.rosenberg@dewire.com, spearce@spearce.org
Cc: git@vger.kernel.org, Marek Zawirski <marek.zawirski@gmail.com>
Subject: [EGIT PATCH 1/3] Give NoRemoteRepositoryException better message in BasePackConnection
Date: Thu, 28 Aug 2008 03:36:08 +0200 [thread overview]
Message-ID: <1219887370-17265-1-git-send-email-marek.zawirski@gmail.com> (raw)
Reported-by: Robert <robert_no.spam_m@yahoo.fr>
Signed-off-by: Marek Zawirski <marek.zawirski@gmail.com>
---
See http://code.google.com/p/egit/issues/detail?id=16
.../spearce/jgit/transport/BasePackConnection.java | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackConnection.java b/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackConnection.java
index 14fffc3..de0c7b6 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackConnection.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/transport/BasePackConnection.java
@@ -129,8 +129,15 @@ private void readAdvertisedRefsImpl() throws IOException {
try {
line = pckIn.readString();
} catch (EOFException eof) {
- if (avail.isEmpty())
- throw new NoRemoteRepositoryException(uri, "not found.");
+ if (avail.isEmpty()) {
+ String service = "unknown";
+ if (this instanceof PushConnection)
+ service = "push";
+ else if (this instanceof FetchConnection)
+ service = "fetch";
+ throw new NoRemoteRepositoryException(uri, service
+ + " service not found.");
+ }
throw eof;
}
--
1.5.6.3
next reply other threads:[~2008-08-28 1:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 1:36 Marek Zawirski [this message]
2008-08-28 1:36 ` [EGIT PATCH 2/3] Handle NoRemoteRepositoryException in PushOperation especially Marek Zawirski
2008-08-28 1:36 ` [EGIT PATCH 3/3] Show ErrorDialog fot fatal connection errors in ConfirmationPage Marek Zawirski
2008-08-28 2:21 ` Shawn O. Pearce
2008-08-28 2:30 ` Marek Zawirski
2008-08-28 2:19 ` [EGIT PATCH 2/3] Handle NoRemoteRepositoryException in PushOperation especially Shawn O. Pearce
2008-08-28 2:29 ` Marek Zawirski
2008-08-28 2:35 ` [EGIT PATCH 1/3] Give NoRemoteRepositoryException better message in BasePackConnection Shawn O. Pearce
2008-08-28 2:40 ` Marek Zawirski
2008-08-28 2:44 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219887370-17265-1-git-send-email-marek.zawirski@gmail.com \
--to=marek.zawirski@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).