From: "Eddy Petrișor" <eddy.petrisor@gmail.com>
To: git@vger.kernel.org
Cc: "Eddy Petrișor" <eddy.petrisor@gmail.com>
Subject: [PATCH] git svn: should not display zombie externals
Date: Fri, 29 Aug 2008 03:02:57 +0300 [thread overview]
Message-ID: <1219968179-14156-1-git-send-email-eddy.petrisor@gmail.com> (raw)
In-Reply-To: <60381eeb0808281702q3dc7543enff2b35ebbcc80d08@mail.gmail.com>
subversion does not process in any way empty svn:externals properties
and doesn't list them in any way; git svn externals shouldn't do that
either
Signed-off-by: Eddy Petrișor <eddy.petrisor@gmail.com>
---
t/t9101-git-svn-props.sh | 24 +++++++++++++++++++++++-
1 files changed, 23 insertions(+), 1 deletions(-)
diff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh
index f420796..e174b30 100755
--- a/t/t9101-git-svn-props.sh
+++ b/t/t9101-git-svn-props.sh
@@ -211,7 +211,29 @@ EOF
test_expect_success 'test proplist' "
git-svn proplist . | cmp - prop.expect &&
- git-svn proplist nested/directory/.keep | cmp - prop2.expect
+ git-svn proplist nested/directory/.keep | cmp - prop2.expect &&
+ cd ..
+ "
+
+test_expect_success 'show external' "
+ cd test_wc &&
+ svn mkdir zombie &&
+ svn propset svn:externals 'externaldir file:///fake/external' zombie &&
+ svn ci -m 'added a fake svn:external' &&
+ cd .. &&
+ git-svn fetch &&
+ git-merge git-svn &&
+ git-svn show-externals | grep -q 'externaldir'
+ "
+
+test_expect_failure 'remove external' "
+ cd test_wc &&
+ svn propset svn:externals '' zombie &&
+ svn ci -m 'deleted the fake external' &&
+ cd .. &&
+ git-svn fetch &&
+ git-merge git-svn &&
+ git-svn show-externals | grep -v ^# | grep -v ^$ | grep -q -v '^/zombie'
"
test_done
--
1.5.6.3
next prev parent reply other threads:[~2008-08-29 0:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 0:02 [PATCH 0/3] git-svn-externals PoC (in a sh script) Eddy Petrișor
2008-08-29 0:02 ` Eddy Petrișor [this message]
2008-08-29 0:02 ` [PATCH] First crude implementation of git-svn-externals Eddy Petrișor
2008-08-29 0:02 ` [PATCH] added a test frame for git-svn-externals.sh Eddy Petrișor
2008-08-29 0:16 ` [PATCH 0/3] git-svn-externals PoC (in a sh script) Eddy Petrișor
2008-08-29 9:29 ` Eric Wong
2008-09-01 6:20 ` RFH: git-svn and submodules Eric Wong
2008-09-10 13:56 ` [PATCH 0/3] git-svn-externals PoC (in a sh script) Eddy Petrișor
2008-09-10 13:59 ` Eddy Petrișor
-- strict thread matches above, loose matches on Subject: below --
2008-07-31 22:33 [PATCH] git svn: should not display zombie externals Eddy Petrișor
2008-07-31 22:37 ` Eddy Petrișor
2008-08-12 17:05 ` Eddy Petrișor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219968179-14156-1-git-send-email-eddy.petrisor@gmail.com \
--to=eddy.petrisor@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).