git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Document clarification: gitmodules, gitattributes
@ 2008-08-31 16:00 Gustaf Hendeby
  2008-08-31 16:38 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Gustaf Hendeby @ 2008-08-31 16:00 UTC (permalink / raw)
  To: gitster; +Cc: git, Gustaf Hendeby

The SYNOPSIS section of gitattibutes and gitmodule fail to clearly
specify the name of the in tree files used.  This patch brings in the
initial `.' and the fact that the `.gitmodules' file should reside at
the top-level of the working tree.

Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se>
---

If this patch isn't accepted, the reverse changes should be made to
the gitignore documentation.

/Gustaf

 Documentation/gitattributes.txt |    2 +-
 Documentation/gitmodules.txt    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
index 1f23d27..5fb5007 100644
--- a/Documentation/gitattributes.txt
+++ b/Documentation/gitattributes.txt
@@ -7,7 +7,7 @@ gitattributes - defining attributes per path
 
 SYNOPSIS
 --------
-$GIT_DIR/info/attributes, gitattributes
+$GIT_DIR/info/attributes, .gitattributes
 
 
 DESCRIPTION
diff --git a/Documentation/gitmodules.txt b/Documentation/gitmodules.txt
index f8d122a..d1a17e2 100644
--- a/Documentation/gitmodules.txt
+++ b/Documentation/gitmodules.txt
@@ -7,7 +7,7 @@ gitmodules - defining submodule properties
 
 SYNOPSIS
 --------
-gitmodules
+$GIT_WORK_DIR/.gitmodules
 
 
 DESCRIPTION
-- 
1.6.0.1.258.g6c63a

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Document clarification: gitmodules, gitattributes
  2008-08-31 16:00 [PATCH] Document clarification: gitmodules, gitattributes Gustaf Hendeby
@ 2008-08-31 16:38 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2008-08-31 16:38 UTC (permalink / raw)
  To: Gustaf Hendeby; +Cc: git

Gustaf Hendeby <hendeby@isy.liu.se> writes:

> The SYNOPSIS section of gitattibutes and gitmodule fail to clearly
> specify the name of the in tree files used.  This patch brings in the
> initial `.' and the fact that the `.gitmodules' file should reside at
> the top-level of the working tree.
>
> Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se>
> ---
>
> If this patch isn't accepted, the reverse changes should be made to
> the gitignore documentation.

The sole reason they lacked the initial "." was because AsciiDOC
mishandled ".gitmodules" that began the line; we used to have the dot but
removed it as a workaround because we couldn't find a good solution by
tweaking the mark-up.

By prefixing "$GIT_FOOBAR/" in front of them, your patch makes the issue
go away while conveying the fact that it has to be at the toplevel of the
work tree, not anywhere in the tree.  Very nice.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-08-31 16:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-31 16:00 [PATCH] Document clarification: gitmodules, gitattributes Gustaf Hendeby
2008-08-31 16:38 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).