From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <sop@google.com>
Subject: [JGIT PATCH] RevWalk: Fix RevSort.REVERSE combined with RevSort.TOPO
Date: Sun, 7 Sep 2008 14:00:08 -0700 [thread overview]
Message-ID: <1220821208-13420-1-git-send-email-spearce@spearce.org> (raw)
From: Shawn O. Pearce <sop@google.com>
The reverse sort was using the initial pending queue, not the
generator that comes before it in the workflow. This caused
a combination of TOPO and REVERSE to return no commits.
Signed-off-by: Shawn O. Pearce <sop@google.com>
---
.../org/spearce/jgit/revwalk/StartGenerator.java | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/revwalk/StartGenerator.java b/org.spearce.jgit/src/org/spearce/jgit/revwalk/StartGenerator.java
index 7ddcd3c..1b7947f 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/revwalk/StartGenerator.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/revwalk/StartGenerator.java
@@ -144,7 +144,7 @@ RevCommit next() throws MissingObjectException,
&& (g.outputType() & SORT_TOPO) == 0)
g = new TopoSortGenerator(g);
if (walker.hasRevSort(RevSort.REVERSE))
- g = new LIFORevQueue(q);
+ g = new LIFORevQueue(g);
if (boundary)
g = new BoundaryGenerator(w, g);
--
1.6.0.1.319.g9f32b
next reply other threads:[~2008-09-07 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 21:00 Shawn O. Pearce [this message]
2008-09-07 21:03 ` [JGIT PATCH] RevWalk: Fix RevSort.REVERSE combined with RevSort.TOPO Shawn O. Pearce
2008-09-07 21:21 ` Robin Rosenberg
2008-09-07 21:32 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220821208-13420-1-git-send-email-spearce@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=sop@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).