From: Petr Baudis <pasky@suse.cz>
To: git@vger.kernel.org
To: git@vger.kernel.org
Cc: spearce@spearce.org
Subject: [PATCH] Fix removing non-pushable remotes
Date: Thu, 25 Sep 2008 01:32:47 +0200 [thread overview]
Message-ID: <1222299167-4305-1-git-send-email-pasky@suse.cz> (raw)
In-Reply-To: <20080924204616.189163849@suse.cz>
Git-gui does not add most of the remotes to the 'push' menu
since they are missing the "Push" line in their remotespec.
In that case, removing the remote would end up with an error.
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
Note that I think this should be abandoned and all remotes
added to the push menu. Having the push part of the remotespec
is actually a very rare situation and it is just not there
in most of the cases, relying on default git push behaviour.
git-gui/lib/remote.tcl | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/git-gui/lib/remote.tcl b/git-gui/lib/remote.tcl
index 1852247..b92b429 100644
--- a/git-gui/lib/remote.tcl
+++ b/git-gui/lib/remote.tcl
@@ -271,5 +271,6 @@ proc remove_remote {name} {
delete_from_menu $remote_m.fetch $name
delete_from_menu $remote_m.prune $name
delete_from_menu $remote_m.remove $name
- delete_from_menu $remote_m.push $name
+ # Not all remotes are in the push menu
+ catch { delete_from_menu $remote_m.push $name }
}
--
tg: (17f0c43..) t/git-gui/remove-push (depends on: git-gui/remotes)
next prev parent reply other threads:[~2008-09-24 23:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 20:43 [PATCH 0/5] git-gui: Remotes manipulation enhancements pasky
2008-09-24 20:43 ` [PATCH 1/5] git-gui: Clarify the Remote -> Delete... action pasky
2008-09-24 20:44 ` [PATCH 2/5] git-gui: Squash populate_{push,fetch}_menu to populate_remotes_menu pasky
2008-09-24 20:44 ` [PATCH 3/5] git-gui: Add support for adding remotes pasky
2008-09-24 23:39 ` [PATCH] git-gui: Fix fetching from remotes when adding them Petr Baudis
2008-09-24 20:44 ` [PATCH 4/5] git-gui: Add support for removing remotes pasky
2008-09-24 23:32 ` Petr Baudis [this message]
2008-09-24 20:44 ` [PATCH 5/5] git-gui: mkdir -p when initializing new remote repository pasky
2008-09-24 22:51 ` On Sponsor Notices Petr Baudis
2008-09-24 22:55 ` Heikki Orsila
2008-09-24 23:43 ` Martin Langhoff
2008-09-24 23:47 ` Petr Baudis
2008-09-24 23:50 ` Martin Langhoff
2008-09-25 2:36 ` Nicolas Pitre
2008-09-25 10:15 ` Petr Baudis
2008-09-25 14:20 ` Nicolas Pitre
2008-09-25 14:32 ` Petr Baudis
2008-09-25 14:35 ` Shawn O. Pearce
2008-09-25 6:12 ` Andreas Ericsson
2008-09-26 13:31 ` A.J. Rossini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222299167-4305-1-git-send-email-pasky@suse.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).