From: Gustaf Hendeby <hendeby@isy.liu.se>
To: git@vger.kernel.org
Cc: spearce@spearce.org, Gustaf Hendeby <hendeby@isy.liu.se>
Subject: [PATCH] git-gui: Help identify aspell version on Windows too
Date: Thu, 25 Sep 2008 23:31:22 +0200 [thread overview]
Message-ID: <1222378282-21757-1-git-send-email-hendeby@isy.liu.se> (raw)
On windows, git gui fails to correctly extract the aspell version
(experienced with aspell version 0.50.3) due to scilent white space at
the end of the version string. Trim the obtained version string to
work around this.
Signed-off-by: Gustaf Hendeby <hendeby@isy.liu.se>
---
lib/spellcheck.tcl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/spellcheck.tcl b/lib/spellcheck.tcl
index 78f344f..c8cc030 100644
--- a/lib/spellcheck.tcl
+++ b/lib/spellcheck.tcl
@@ -80,7 +80,7 @@ method _connect {pipe_fd} {
error_popup [strcat [mc "Unrecognized spell checker"] ":\n\n$s_version"]
return
}
- set s_version [string range $s_version 5 end]
+ set s_version [string range [string trim $s_version] 5 end]
regexp \
{International Ispell Version .* \(but really (Aspell .*?)\)$} \
$s_version _junk s_version
--
1.6.0.2.509.g4def
next reply other threads:[~2008-09-25 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 21:31 Gustaf Hendeby [this message]
2008-09-26 6:29 ` [PATCH] git-gui: Help identify aspell version on Windows too Johannes Sixt
2008-09-26 9:05 ` Gustaf Hendeby
2008-09-26 9:31 ` Johannes Sixt
2008-09-26 14:31 ` Shawn O. Pearce
2008-09-26 15:06 ` Johannes Sixt
2008-09-26 14:28 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222378282-21757-1-git-send-email-hendeby@isy.liu.se \
--to=hendeby@isy.liu.se \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).