From: Petr Baudis <pasky@suse.cz>
To: git@vger.kernel.org
To: git@vger.kernel.org
Cc: spearce@spearce.org, Petr Baudis <petr.baudis@novartis.com>
Subject: [PATCH] git-gui: Correctly set up locators in case of preset URL variable
Date: Fri, 3 Oct 2008 12:13:46 +0200 [thread overview]
Message-ID: <1223028826-10306-1-git-send-email-pasky@suse.cz> (raw)
In-Reply-To: <20080930195839.GK21310@spearce.org>
This patch fixes locators setup in case the URL variable is already set,
e.g. in the clone dialog during 'git gui clone'.
Signed-off-by: Petr Baudis <petr.baudis@novartis.com>
---
git-gui/lib/transport.tcl | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/git-gui/lib/transport.tcl b/git-gui/lib/transport.tcl
index 277e6b8..02c4eca 100644
--- a/git-gui/lib/transport.tcl
+++ b/git-gui/lib/transport.tcl
@@ -68,8 +68,13 @@ proc location_input {widget urlvar op} {
global _locator_template _locator_input _locator_var
trace remove variable _locator_input write locator_update
- set _locator_template $default_locator
- set _locator_input {}
+ if {[set $urlvar] == {}} {
+ set _locator_template $default_locator
+ set _locator_input {}
+ } else {
+ set _locator_template "URL"
+ set _locator_input [set $urlvar]
+ }
set _locator_var $urlvar
trace add variable _locator_input write locator_update
--
tg: (3c6c738..) t/git-gui/locator-preset (depends on: git-gui/locators t/git-gui/clonecmd)
next prev parent reply other threads:[~2008-10-03 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 16:51 [PATCH] git-gui: Implement a 'clone' subcommand Petr Baudis
2008-09-30 19:53 ` Shawn O. Pearce
2008-09-30 19:58 ` Shawn O. Pearce
2008-10-03 10:13 ` Petr Baudis [this message]
2008-10-03 10:23 ` [PATCH] git-gui: Correctly set up locators in case of preset URL variable H.Merijn Brand
2008-10-03 10:48 ` Petr Baudis
2008-10-10 16:42 ` Shawn O. Pearce
2008-10-03 10:17 ` [PATCH] git-gui: Implement a 'clone' subcommand Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223028826-10306-1-git-send-email-pasky@suse.cz \
--to=pasky@suse.cz \
--cc=git@vger.kernel.org \
--cc=petr.baudis@novartis.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).