git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt McCutchen <matt@mattmccutchen.net>
To: git@vger.kernel.org
Subject: [PATCH] t1301-shared-repo.sh: don't let a default ACL interfere with the test
Date: Tue, 14 Oct 2008 18:07:00 -0400	[thread overview]
Message-ID: <1224022020.2699.4.camel@mattlaptop2.local> (raw)

This test creates files with several different umasks and expects the files to
be permissioned according to the umasks, so a default ACL on the test dir causes
the test to fail.  To avoid that, remove the default ACL if possible with
setfacl(1).  (Will work on many systems.)
---
 t/t1301-shared-repo.sh |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh
index dc85e8b..2275caa 100755
--- a/t/t1301-shared-repo.sh
+++ b/t/t1301-shared-repo.sh
@@ -7,6 +7,9 @@ test_description='Test shared repository initialization'
 
 . ./test-lib.sh
 
+# Remove a default ACL from the test dir if possible.
+setfacl -k . 2>/dev/null
+
 # User must have read permissions to the repo -> failure on --shared=0400
 test_expect_success 'shared = 0400 (faulty permission u-w)' '
 	mkdir sub && (
-- 
1.6.0.2.530.gb503b

             reply	other threads:[~2008-10-14 22:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-14 22:07 Matt McCutchen [this message]
2008-10-14 22:10 ` [PATCH try 2] t1301-shared-repo.sh: don't let a default ACL interfere with the test Matt McCutchen
2008-10-14 22:32   ` Junio C Hamano
2008-10-14 23:00     ` Matt McCutchen
2008-10-14 23:45       ` Deskin Miller
2008-10-15  6:13     ` Johannes Sixt
2008-10-15  6:30       ` Junio C Hamano
2008-10-15  7:18         ` Johannes Sixt
2008-10-15  7:57           ` Junio C Hamano
2008-10-15  8:10             ` Johannes Sixt
2008-10-16  5:23               ` Junio C Hamano
2008-10-17  2:28                 ` Matt McCutchen
2008-10-17  4:30                   ` Junio C Hamano
2008-10-17  4:33                     ` Matt McCutchen
2008-10-17  2:28                 ` [PATCH try 3] " Matt McCutchen
2008-10-17  2:32                 ` [PATCH try 4] " Matt McCutchen
2008-10-15 14:34       ` [PATCH try 2] " Matt McCutchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224022020.2699.4.camel@mattlaptop2.local \
    --to=matt@mattmccutchen.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).