git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Gavrilov <angavrilov@gmail.com>
To: git@vger.kernel.org
Cc: msysgit@googlegroups.com,
	Johannes Sixt <johannes.sixt@telecom.at>,
	"Shawn O. Pearce" <spearce@spearce.org>,
	Junio C Hamano <gitster@pobox.com>
Subject: [PATCH (GIT-GUI,MINGW) 0/3] Fix OpenSSH & Git-Gui integration in msysgit
Date: Mon, 20 Oct 2008 20:02:17 +0400	[thread overview]
Message-ID: <1224518540-23782-1-git-send-email-angavrilov@gmail.com> (raw)


It is a well known problem on msysgit that when ssh is started
from git-gui during a fetch, any situations where it normally
displays a prompt to the user cause it to hang silently. It is
even worse than the situation on Linux, where the prompts appear
on the terminal that started the GUI.

This combination of 3 patches aims to eliminate this problem. One
of them changes a flag that is used to spawn the ssh executable,
to make it recognize that it does not have a valid controlling
console. The other two add features to git-gui that make ssh
usage more convenient, including a simple implementation of an
SSH_ASKPASS program.

When the patches are applied, all SSH prompts in msysgit
appear in a GUI dialog box in the middle of the screen.
Additionally, it is possible to view or create an OpenSSH
key pair directly from git-gui.


Note: This was already posted to the msysgit list. The only differences
      are that git-gui now sets a more evidently fake value for DISPLAY,
      and the last patch has been acked.


GIT-GUI:

	git-gui: Add a dialog that shows the OpenSSH public key.
	---
	 git-gui.sh     |    4 ++
	 lib/sshkey.tcl |  126 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
	 2 files changed, 130 insertions(+), 0 deletions(-)
	 create mode 100644 lib/sshkey.tcl

	git-gui: Add a simple implementation of SSH_ASKPASS.
	---
	 Makefile         |    2 ++
	 git-gui.sh       |   12 ++++++++++++
	 git-gui--askpass |   59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
	 3 files changed, 73 insertions(+), 0 deletions(-)
	 create mode 100755 git-gui--askpass


CORE(MINGW):

	Windows: Make OpenSSH properly detect tty detachment.
	---
	 compat/mingw.c |    8 ++++++--
	 1 files changed, 6 insertions(+), 2 deletions(-)

             reply	other threads:[~2008-10-20 16:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20 16:02 Alexander Gavrilov [this message]
2008-10-20 16:02 ` [PATCH (GIT-GUI,MINGW) 1/3] git-gui: Add a dialog that shows the OpenSSH public key Alexander Gavrilov
2008-10-20 16:02   ` [PATCH (GIT-GUI,MINGW) 2/3] git-gui: Add a simple implementation of SSH_ASKPASS Alexander Gavrilov
2008-10-20 16:02     ` [PATCH (GIT-GUI,MINGW) 3/3] Windows: Make OpenSSH properly detect tty detachment Alexander Gavrilov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224518540-23782-1-git-send-email-angavrilov@gmail.com \
    --to=angavrilov@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.sixt@telecom.at \
    --cc=msysgit@googlegroups.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).