From: Sam Vilain <sam@vilain.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Subject: Re: [PATCH] Use find instead of perl in t5000 to get file modification time
Date: Wed, 29 Oct 2008 22:29:14 -0700 [thread overview]
Message-ID: <1225344554.10803.17.camel@maia.lan> (raw)
In-Reply-To: <81b0412b0810290338j1beaa25bx9fb373a69f5dfe7@mail.gmail.com>
On Wed, 2008-10-29 at 11:38 +0100, Alex Riesen wrote:
> I could not find what exactly does the ActiveState's Perl use for its stat
> implementation (and honestly, have no motivation to look harder).
> It seems to honor TZ, but the produced time does not seem to be either
> local or GMT.
See, the difference is that the perl is portable and your patch isn't.
Can you at least reveal how far out the value printed by the perl
fragment was from the expected value, and what your TZ offset is in
seconds. It might be pointing to a deeper problem that could affect
more than just this test case.
Sam.
next prev parent reply other threads:[~2008-10-30 16:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 10:38 [PATCH] Use find instead of perl in t5000 to get file modification time Alex Riesen
2008-10-29 21:54 ` Jeff King
2008-10-30 7:26 ` Alex Riesen
2008-10-30 5:29 ` Sam Vilain [this message]
2008-10-31 7:00 ` Alex Riesen
2008-10-31 12:59 ` Peter Harris
2008-10-31 13:45 ` Alex Riesen
2008-10-31 22:14 ` Johannes Schindelin
2008-10-31 23:37 ` Alex Riesen
2008-11-01 0:23 ` Johannes Schindelin
2008-11-01 14:24 ` Alex Riesen
2008-11-01 20:37 ` Johannes Schindelin
2008-11-02 14:37 ` Alex Riesen
2008-11-02 16:05 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225344554.10803.17.camel@maia.lan \
--to=sam@vilain.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=raa.lkml@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).