From: crquan@gmail.com
To: git@vger.kernel.org
Subject: [PATCH 3/3] git-remote: simplifying get_one_entry
Date: Mon, 17 Nov 2008 19:15:51 +0800 [thread overview]
Message-ID: <1226920551-28303-3-git-send-email-crquan@gmail.com> (raw)
In-Reply-To: <1226920551-28303-2-git-send-email-crquan@gmail.com>
From: Cheng Renquan <crquan@gmail.com>
The loop for remote->url_nr is really useless,
set to the last one directly is better.
Signed-off-by: Cheng Renquan <crquan@gmail.com>
---
builtin-remote.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/builtin-remote.c b/builtin-remote.c
index fff9920..59d69a5 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -839,13 +839,9 @@ static int get_one_entry(struct remote *remote, void *priv)
{
struct string_list *list = priv;
- if (remote->url_nr > 0) {
- int i;
-
- for (i = 0; i < remote->url_nr; i++)
- string_list_append(remote->name, list)->util = (void *)remote->url[i];
- } else
- string_list_append(remote->name, list)->util = NULL;
+ string_list_append(remote->name, list)->util =
+ remote->url_nr > 0
+ ? (void *)remote->url[remote->url_nr-1] : NULL;
return 0;
}
--
1.6.0.2
next prev parent reply other threads:[~2008-11-17 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 11:15 [PATCH 1/3] git-remote: match usage string with the manual pages crquan
2008-11-17 11:15 ` [PATCH 2/3] git-remote: add verbose mode to git remote update crquan
2008-11-17 11:15 ` crquan [this message]
2008-11-17 16:48 ` [PATCH 3/3] git-remote: simplifying get_one_entry Junio C Hamano
2008-11-18 0:56 ` rae l
2008-11-17 16:46 ` [PATCH 2/3] git-remote: add verbose mode to git remote update Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1226920551-28303-3-git-send-email-crquan@gmail.com \
--to=crquan@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).