* [PATCH] Retain multiple -q/-v occurrences in git pull
@ 2008-11-17 22:09 Tuncer Ayaz
2008-11-19 1:53 ` Junio C Hamano
2008-11-19 11:46 ` Constantine Plotnikov
0 siblings, 2 replies; 6+ messages in thread
From: Tuncer Ayaz @ 2008-11-17 22:09 UTC (permalink / raw)
To: git; +Cc: gitster
To support counting -q/-v options in git pull retain
them by concatenating.
Signed-off-by: Tuncer Ayaz <tuncer.ayaz@gmail.com>
---
git-pull.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-pull.sh b/git-pull.sh
index 8866f2a..1cac898 100755
--- a/git-pull.sh
+++ b/git-pull.sh
@@ -24,9 +24,9 @@ while :
do
case "$1" in
-q|--quiet)
- verbosity=-q ;;
+ verbosity="$verbosity -q" ;;
-v|--verbose)
- verbosity=-v ;;
+ verbosity="$verbosity -v" ;;
-n|--no-stat|--no-summary)
no_stat=-n ;;
--stat|--summary)
--
1.6.0.2.GIT
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Retain multiple -q/-v occurrences in git pull
2008-11-17 22:09 [PATCH] Retain multiple -q/-v occurrences in git pull Tuncer Ayaz
@ 2008-11-19 1:53 ` Junio C Hamano
2008-11-19 11:46 ` Constantine Plotnikov
1 sibling, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2008-11-19 1:53 UTC (permalink / raw)
To: Tuncer Ayaz; +Cc: git
Thanks, queued.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Retain multiple -q/-v occurrences in git pull
2008-11-17 22:09 [PATCH] Retain multiple -q/-v occurrences in git pull Tuncer Ayaz
2008-11-19 1:53 ` Junio C Hamano
@ 2008-11-19 11:46 ` Constantine Plotnikov
2008-11-19 22:47 ` Tuncer Ayaz
1 sibling, 1 reply; 6+ messages in thread
From: Constantine Plotnikov @ 2008-11-19 11:46 UTC (permalink / raw)
To: Tuncer Ayaz; +Cc: git, gitster
On Tue, Nov 18, 2008 at 1:09 AM, Tuncer Ayaz <tuncer.ayaz@gmail.com> wrote:
> To support counting -q/-v options in git pull retain
> them by concatenating.
>
[rest of message cut]
By the way, there is yet another way to invoke git fetch. It is "git
remote update". Possibly it should support "-v" and "-q" options for
consistency as well.
Regards,
Constantine
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Retain multiple -q/-v occurrences in git pull
2008-11-19 11:46 ` Constantine Plotnikov
@ 2008-11-19 22:47 ` Tuncer Ayaz
[not found] ` <4ac8254d0811191458r2a205be3w4a412553edc9b07f@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Tuncer Ayaz @ 2008-11-19 22:47 UTC (permalink / raw)
To: Constantine Plotnikov; +Cc: git, gitster
On Wed, Nov 19, 2008 at 12:46 PM, Constantine Plotnikov
<constantine.plotnikov@gmail.com> wrote:
> On Tue, Nov 18, 2008 at 1:09 AM, Tuncer Ayaz <tuncer.ayaz@gmail.com> wrote:
>> To support counting -q/-v options in git pull retain
>> them by concatenating.
>>
> [rest of message cut]
>
> By the way, there is yet another way to invoke git fetch. It is "git
> remote update". Possibly it should support "-v" and "-q" options for
> consistency as well.
Yes, we could add -q to builtin-remote and also make sure that it
passes the already existing -v and maybe a yet-to-be-added -q to
the fetch command.
I want to be first sure what the overall strategy regarding -q/-v is.
Right now we have some code which uses OPT__VERBOSE/OPT__QUIET
and some new code which uses the newly-added OPT__VERBOSITY.
These are the options I can see:
1) Use the old and new macros and decide in each module which one to use
2) Get rid off OPT__VERBOSE and OPT__QUIET and use OPT__VERBOSITY only
3) Think about new ways to handle all of this. Possibly some new print_* macros?
Any opinions?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Retain multiple -q/-v occurrences in git pull
@ 2008-11-17 22:10 Tuncer Ayaz
0 siblings, 0 replies; 6+ messages in thread
From: Tuncer Ayaz @ 2008-11-17 22:10 UTC (permalink / raw)
To: gitster; +Cc: git
To support counting -q/-v options in git pull retain
them by concatenating.
Signed-off-by: Tuncer Ayaz <tuncer.ayaz@gmail.com>
---
git-pull.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-pull.sh b/git-pull.sh
index 8866f2a..1cac898 100755
--- a/git-pull.sh
+++ b/git-pull.sh
@@ -24,9 +24,9 @@ while :
do
case "$1" in
-q|--quiet)
- verbosity=-q ;;
+ verbosity="$verbosity -q" ;;
-v|--verbose)
- verbosity=-v ;;
+ verbosity="$verbosity -v" ;;
-n|--no-stat|--no-summary)
no_stat=-n ;;
--stat|--summary)
--
1.6.0.2.GIT
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-11-19 23:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-17 22:09 [PATCH] Retain multiple -q/-v occurrences in git pull Tuncer Ayaz
2008-11-19 1:53 ` Junio C Hamano
2008-11-19 11:46 ` Constantine Plotnikov
2008-11-19 22:47 ` Tuncer Ayaz
[not found] ` <4ac8254d0811191458r2a205be3w4a412553edc9b07f@mail.gmail.com>
2008-11-19 23:00 ` Tuncer Ayaz
-- strict thread matches above, loose matches on Subject: below --
2008-11-17 22:10 Tuncer Ayaz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).