From: "martin f. krafft" <madduck@debian.org>
To: git@vger.kernel.org
Cc: "martin f. krafft" <madduck@debian.org>
Subject: [TopGit PATCH] Check for help invocation before setup
Date: Wed, 19 Nov 2008 17:03:40 +0100 [thread overview]
Message-ID: <1227110623-4474-2-git-send-email-madduck@debian.org> (raw)
In-Reply-To: <1227110623-4474-1-git-send-email-madduck@debian.org>
The user ought to be able to call `tg help` from anywhere in the
filesystem, not just Git repositories, so the help parsing has to happen
before the calls to git git binary.
Debian bug: #501982
Signed-off-by: martin f. krafft <madduck@debian.org>
---
tg.sh | 17 ++++++++++++++---
1 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/tg.sh b/tg.sh
index 2961106..40c4ab7 100644
--- a/tg.sh
+++ b/tg.sh
@@ -235,6 +235,20 @@ do_help()
fi
}
+## Startup
+
+args_saved="$@"
+while [ -n "$1" ]; do
+ case "$1" in
+ help|--help|-h)
+ shift
+ do_help "$1"
+ exit 1;;
+ esac
+ shift
+done
+set -- $args_saved
+unset args_saved
## Initial setup
@@ -268,9 +282,6 @@ cmd="$1"
shift
case "$cmd" in
-help|--help|-h)
- do_help "$1"
- exit 1;;
--hooks-path)
# Internal command
echo "@hooksdir@";;
--
1.6.0.2
next prev parent reply other threads:[~2008-11-19 16:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 16:03 [TopGit] Improve help output martin f. krafft
2008-11-19 16:03 ` martin f. krafft [this message]
2008-11-19 16:03 ` [TopGit PATCH] Change tg help exit code to 0 martin f. krafft
2008-11-19 16:03 ` [TopGit PATCH] Check for cmddir earlier martin f. krafft
2008-11-19 16:03 ` [TopGit PATCH] Print help output when no command is given martin f. krafft
2008-11-19 18:24 ` [TopGit PATCH] Check for help invocation before setup Petr Baudis
2008-11-19 18:32 ` martin f krafft
2008-11-19 18:39 ` Petr Baudis
2008-11-20 11:48 ` martin f krafft
2008-11-21 9:19 ` Bert Wesarg
2008-11-21 12:06 ` TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup) martin f krafft
2008-11-21 12:09 ` [TopGit PATCH] Ensure we are inside a Git worktree martin f. krafft
2008-11-21 12:15 ` TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup) Bert Wesarg
2008-11-21 12:18 ` Bert Wesarg
2008-11-21 12:31 ` martin f krafft
2008-11-21 12:23 ` martin f krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227110623-4474-2-git-send-email-madduck@debian.org \
--to=madduck@debian.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).